Bug 1543039 - [3.8] Failed to unbind after deleting templateinstance with servicebinding existing
Summary: [3.8] Failed to unbind after deleting templateinstance with servicebinding ex...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Service Broker
Version: 3.8.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: 3.8.0
Assignee: Ben Parees
QA Contact: XiuJuan Wang
URL:
Whiteboard:
Depends On: 1540819 1543044
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-07 15:43 UTC by Ben Parees
Modified: 2021-03-11 17:08 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: Unbinding a template service instance throws an error if the template service instance was deleted. Consequence: It becomes impossible to unbind a service instance if the template service instance was manually deleted, including if the project containing the TSI was deleted. Fix: The template service broker will return success/gone in cases where the unbind refers to a non-existent template service instance. Result: The unbind can proceed even if the TSI no longer exists.
Clone Of: 1540819
Environment:
Last Closed: 2018-03-06 14:51:44 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 1 Ben Parees 2018-02-07 19:03:59 UTC
https://github.com/openshift/ose/pull/1053

Comment 2 Ben Parees 2018-02-12 14:59:06 UTC
this is the master origin pr, putting it here to quiet the bot.  The backport was done directly to ose per comment 1.

https://github.com/openshift/origin/pull/18416

Comment 3 XiuJuan Wang 2018-03-06 10:12:00 UTC
Ben,
Is it necessery to fix this bug in ocp 3.8 since 3.8 is not a release version?

Also I checked this bug in ocp 3.8.32 with ose-template-service-broker:v3.8.32 and ose-service-catalog:v3.8.32, still could reprodude this issue in that version

openshift v3.8.32
kubernetes v1.8.5+440f8d36da

# docker images 
REPOSITORY                                                                  TAG                 IMAGE ID            CREATED             SIZE

registry.reg-aws.openshift.com:443/openshift3/ose-haproxy-router            v3.8.32             fabbb249ec3a        5 weeks ago         1.295 GB
registry.reg-aws.openshift.com:443/openshift3/ose-deployer                  v3.8.32             bd25dca6143c        5 weeks ago         1.276 GB
registry.reg-aws.openshift.com:443/openshift3/ose                           v3.8.32             d093c6b8ca7d        5 weeks ago         1.276 GB
registry.reg-aws.openshift.com:443/openshift3/ose-docker-registry           v3.8.32             57f1df86088e        5 weeks ago         476.7 MB
registry.reg-aws.openshift.com:443/openshift3/ose-template-service-broker   v3.8.32             4e7680566973        5 weeks ago         269.8 MB
registry.reg-aws.openshift.com:443/openshift3/ose-service-catalog           v3.8.32             6793e5794a89        5 weeks ago         268.8 MB
registry.reg-aws.openshift.com:443/openshift3/ose-pod                       v3.8.32             afabbd610e15        5 weeks ago         208.9 MB

Comment 4 Ben Parees 2018-03-06 14:51:44 UTC
> Is it necessery to fix this bug in ocp 3.8 since 3.8 is not a release version?

probably not strictly necessary, I was just trying to be thorough in my backports.

> Also I checked this bug in ocp 3.8.32 with ose-template-service-broker:v3.8.32 and ose-service-catalog:v3.8.32, still could reprodude this issue in that version


given that your images are 5 weeks old and this merged 4 weeks ago, i'm not surprised you're still seeing the issue.  I don't know what the story is with 3.8 in terms of building new images, perhaps they are not doing so.

(Just confirmed w/ Jessica that we are probably not building 3.8 images anymore, i'm just going to close this as won't fix as it's not necessary to fix it in 3.8).


Note You need to log in before you can comment on or make changes to this bug.