Bug 1546059
| Summary: | Stack traces in journal | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Jiri Koten <jkoten> | ||||||
| Component: | gjs | Assignee: | Ray Strode [halfline] <rstrode> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 7.5 | CC: | angystardust, bgollahe, desktop-qa-list, fmuellner, jan.public, klember, redhat, rstrode, tpelka, wchadwic | ||||||
| Target Milestone: | rc | Keywords: | Regression | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| URL: | https://gitlab.gnome.org/GNOME/gjs/merge_requests/71 | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | gjs-1.50.4-4.el7 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | 1545659 | Environment: | |||||||
| Last Closed: | 2018-04-10 13:13:04 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 1545659 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Jiri Koten
2018-02-16 08:49:57 UTC
Let's fix this for 7.5 by patching out the traces from gjs and downgrading the g_criticals to g_debug, which still enables app writers to see the errors, but doesn't spam the system journal. Created attachment 1397088 [details]
Avoid emitting critical warnings for finalized objects
Here's a patch to the package file that does this -- attaching it here for reference. halfline was talking about keeping the gjs_dumpstack() calls as well, but doing it conditionally only when debugging is enabled, and if it works we'll probably go with that instead.
Created attachment 1397147 [details]
object: only print stacktraces when debugging enabled
We have a bunch of corruption right now spamming the
log.
This commit gets rid of the spam unless G_MESSAGES_DEBUG
is set.
Provided blocker "+" for tpelka I can confirm that stack traces for critical warnings are only printed when G_MESSAGES_DEBUG is set. This also happens in Fedora 27. Should I open a new bug or can the description be widened to be not RHEL specific? $ rpm -q gjs gnome-shell gjs-1.50.4-1.fc27.x86_64 gnome-shell-3.26.2-4.fc27.x86_64 Christian, it's expected in Fedora at the moment. The best thing you can do is file the traces you see upstream here: https://gitlab.gnome.org/GNOME/gnome-shell/issues/new so they can be fixed one by one ! Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:0770 |