Bug 1547373

Summary: sd_journal can "leak" fds if it starts dropping inotify events [rhel-7.4.z]
Product: Red Hat Enterprise Linux 7 Reporter: Oneata Mircea Teodor <toneata>
Component: systemdAssignee: systemd-maint
Status: CLOSED ERRATA QA Contact: Frantisek Sumsal <fsumsal>
Severity: urgent Docs Contact: Marie Hornickova <mdolezel>
Priority: urgent    
Version: 7.5CC: bbreard, bleanhar, fsumsal, lnykryn, mdolezel, msekleta, pportant, rmeggins, systemd-maint-list, systemd-maint
Target Milestone: rcKeywords: ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: systemd-219-42.el7_4.10 Doc Type: Bug Fix
Doc Text:
If journald rotates the internal log files quickly enough, and an application using the sd_journal API did not read messages fast enough, the API could start losing notifications about deleted internal log files. Consequently, the sd_journal API was not able to close file descriptors for such files, which prevented the files from being removed from the disk by the kernel. To fix this problem, the sd_journal API now re-iterates through internal log files, finds those that were removed, and closes their file descriptors. As a result, the kernel is now able to remove the files completely from the disk.
Story Points: ---
Clone Of: 1540538 Environment:
Last Closed: 2018-03-06 21:50:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1540538    
Bug Blocks:    

Description Oneata Mircea Teodor 2018-02-21 07:49:23 UTC
This bug has been copied from bug #1540538 and has been proposed to be backported to 7.4 z-stream (EUS).

Comment 5 Peter Portante 2018-03-01 16:11:41 UTC
Can you consider this revised text for the "Doc Text"?

If journald rotates the internal log files quickly enough, and an application
using the sd_journal API did not read messages fast enough, the API could start
losing notifications about deleted internal log files.  Consequently, the
sd_journal API would not know to close file descriptors for such files,
preventing them from being removed from the disk by the kernel.

To fix this problem, the sd_journal API now re-iterates through internal log
files, finds those that were removed and closes their file descriptors, allowing
the kernel to remove the files completely from the disk.

Comment 7 errata-xmlrpc 2018-03-06 21:50:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0416