Bug 1547711

Summary:	Metrics is being configured even if validations failed
Product:	[oVirt] ovirt-engine-metrics	Reporter:	Shirly Radco <sradco>
Component:	Generic	Assignee:	Shirly Radco <sradco>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Lukas Svaty <lsvaty>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	1.1.3.1	CC:	bugs, lveyde
Target Milestone:	ovirt-4.2.2	Keywords:	Regression
Target Release:	1.1.3.2	Flags:	rule-engine: ovirt-4.2+ rule-engine: blocker+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-metrics-1.1.3.2-1.el7ev	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-29 10:58:10 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Metrics	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1549163
Bug Blocks:	1475135

Description Shirly Radco 2018-02-21 19:31:52 UTC

Description of problem:
If validations fail all following plays in the playbook should not be run.
Currently even if the validations fail and and the first play , all there plays continue. 

Version-Release number of selected component (if applicable):
1.1.3.1

How reproducible:
100%

Steps to Reproduce:
1. Use an invalid variable in the config.yml
2. Run the ovirt metrics configuration script
3.

Actual results:
The first play ends when it meets the invalid variable but all following plays are run.

Expected results:
All playbook should end

Additional info:

Comment 1 Red Hat Bugzilla Rules Engine 2018-02-22 08:23:42 UTC

This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 2 Lukas Svaty 2018-03-20 11:40:18 UTC

config.yml is lacking validation on all the fields except 1 (BZ#1558519), however, the functionality is working.

verified in ovirt-engine-metrics-1.1.3.3-1.el7ev.noarch

Comment 3 Sandro Bonazzola 2018-03-29 10:58:10 UTC

This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.