Created attachment 1400863 [details] ovirt-host-deploy-ansible Description of problem: When I customizing host deploy process (https://www.ovirt.org/blog/2017/12/host-deploy-customization/) with additional firewalld rule, rule not deployed. host-deploy-post-tasks deployment not visible in ansible host deploy logs. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. setup /etc/ovirt-engine/ansible/ovirt-host-deploy-post-tasks.yml --- - name: Enable custom firewall port firewalld: port: "10050/tcp" permanent: yes immediate: yes state: enabled - name: Print debug information debug: msg: "My custom tasks was successfully executed!" 2. Host reinstall from UI Actual results: No firewalld rule added on host Expected results: firewalld rule added Additional info: this is corresponding item from engine.log: 2018-02-26 15:34:47,917+01 INFO [org.ovirt.engine.core.common.utils.ansible.AnsibleExecutor] (EE-ManagedThreadFactory-engine-Thread-646) [b5ce073f-5dac-4ccc-b8db-6f96da6dce0a] Executing Ansible command: [/usr/bin/ansible-playbook, -v, --private-key=/etc/pki/ovirt-engine/keys/engine_id_rsa, --inventory=/tmp/ansible-inventory5351283305925319216, --extra-vars=host_deploy_cluster_version=4.2, --extra-vars=host_deploy_cluster_name=Default, --extra-vars=host_deploy_gluster_enabled=false, --extra-vars=host_deploy_virt_enabled=true, --extra-vars=host_deploy_vdsm_port=54321, --extra-vars=host_deploy_override_firewall=true, --extra-vars=host_deploy_firewall_type=FIREWALLD, --extra-vars=ansible_port=22, --extra-vars=host_deploy_post_tasks=/etc/ovirt-engine/ansible/ovirt-host-deploy-post-tasks.yml, --extra-vars=host_deploy_ovn_tunneling_interface=194.108.1.145, --extra-vars=host_deploy_ovn_central=null, /usr/share/ovirt-engine/playbooks/ovirt-host-deploy.yml] [Logfile: /var/log/ovirt-engine/host-deploy/ovirt-host-deploy-ansible-20180226153447-ovnode1.lab.vdi.cz.net-b5ce073f-5dac-4ccc-b8db-6f96da6dce0a.log]
Created attachment 1400864 [details] ovirt-host-deploy
Shirly, this: https://github.com/oVirt/ovirt-engine-metrics/blob/master/roles/oVirt.ovirt-initial-validations/validate-config-yml/tasks/main.yml#L9 is causing that nothing after metrics will be run. Can you please separate the ovirt-metrics to be a separate play in the host-deploy playbook, if you need to do such calls?
Raising severity to high and marking as a blocker for 4.2.2 as this is a regression to the original ovirt-host-deploy role functionality introduced in 4.2.0
AFAIU, The meta: end_play only stops the specific play I'm running now. It does not affect other plays or playbooks. I even had this bug https://bugzilla.redhat.com/show_bug.cgi?id=1547711 Where the rest of the plays in the playbook continued running even if the validations failed.
I moved the role so a separate play at the end of the ovirt-host-deploy playbook.
verified i novirt-engine-metrics-1.1.3.3-1.el7ev.noarch
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018. Since the problem described in this bug report should be resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.