Bug 1547711 - Metrics is being configured even if validations failed
Summary: Metrics is being configured even if validations failed
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-metrics
Classification: oVirt
Component: Generic
Version: 1.1.3.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ovirt-4.2.2
: 1.1.3.2
Assignee: Shirly Radco
QA Contact: Lukas Svaty
URL:
Whiteboard:
Depends On: 1549163
Blocks: 1475135
TreeView+ depends on / blocked
 
Reported: 2018-02-21 19:31 UTC by Shirly Radco
Modified: 2018-03-29 10:58 UTC (History)
2 users (show)

Fixed In Version: ovirt-engine-metrics-1.1.3.2-1.el7ev
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-29 10:58:10 UTC
oVirt Team: Metrics
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: blocker+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 88062 0 master MERGED ansible: End playbook based on initial validations 2018-02-22 11:53:46 UTC

Description Shirly Radco 2018-02-21 19:31:52 UTC
Description of problem:
If validations fail all following plays in the playbook should not be run.
Currently even if the validations fail and and the first play , all there plays continue. 

Version-Release number of selected component (if applicable):
1.1.3.1

How reproducible:
100%

Steps to Reproduce:
1. Use an invalid variable in the config.yml
2. Run the ovirt metrics configuration script
3.

Actual results:
The first play ends when it meets the invalid variable but all following plays are run.

Expected results:
All playbook should end

Additional info:

Comment 1 Red Hat Bugzilla Rules Engine 2018-02-22 08:23:42 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 2 Lukas Svaty 2018-03-20 11:40:18 UTC
config.yml is lacking validation on all the fields except 1 (BZ#1558519), however, the functionality is working.

verified in ovirt-engine-metrics-1.1.3.3-1.el7ev.noarch

Comment 3 Sandro Bonazzola 2018-03-29 10:58:10 UTC
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.