Bug 1561996

Summary: [trello XzkI9of3] Deploy Image page cannot pull and deploy private image successfully after creating pull secret
Product: OpenShift Container Platform Reporter: Xingxing Xia <xxia>
Component: Management ConsoleAssignee: Jakub Hadvig <jhadvig>
Status: CLOSED CURRENTRELEASE QA Contact: Yadan Pei <yapei>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.10.0CC: aos-bugs, jhadvig, jokerman, mmccomas, spadgett
Target Milestone: ---   
Target Release: 3.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-05-29 12:14:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1578088    
Bug Blocks:    

Description Xingxing Xia 2018-03-29 10:22:45 UTC 
Description of problem:
Deploy Image page cannot pull and deploy private image successfully after creating pull secret

Version-Release number of selected component (if applicable):
v3.10.0-0.15.0

How reproducible:
Always

Steps to Reproduce:
1. First prepare a private registry image, e.g. docker.io/starxia/myprivate:hello-openshift
2. On OCP web console, click 'Deploy Image'.
3. Under 'Image Name', input above private image, click the search icon, it will show 'Could not load image metadata'.
4. Then click 'create an image pull secret', input right user, password etc, click 'Link secret to a service account', select 'default'.
5. Repeat step 3, now private image can be searched. Click 'Deploy'.
Then check app pod status

Actual results:
4. Check the web-created secret, its format is still old .dockercfg.
5. App pod cannot be running, its status is ErrImagePull and ImagePullBackOff.

Expected results:
4. Web-created secret format should be consistent with command which uses .dockerconfigjson:
$ oc create secret docker-registry mydocker --docker-server=docker.io --docker-username=starxia --docker-password=$MYPASSWORD --docker-email=$MYEMAIL
5. App pod should be running.

Additional info:
There is https://github.com/openshift/origin-web-console/pull/2464 for the format issue, but not merged.
Comment 1 Jakub Hadvig 2018-04-05 14:05:25 UTC 
PR https://github.com/openshift/origin-web-console/pull/2464 was merged. Please try to reproduce the issue now.
Comment 2 Xingxing Xia 2018-04-08 06:41:02 UTC 
Checked in env:
OpenShift Master: v3.10.0-0.16.0
Kubernetes Master: v1.9.1+a0ce1bc657
OpenShift Web Console: v3.10.0-0.16.0
Now web-created pull secret has same '.dockerconfigjson' format with `oc create secret docker-registry ...`. But still it cannot pull private image and pod is ErrImagePull/ImagePullBackOff status due to bug 1561989. Waiting for that bug addressed ...
Comment 4 Xingxing Xia 2018-05-16 08:26:12 UTC 
Still depending on bug 1561989
Comment 5 Xingxing Xia 2018-05-29 02:28:47 UTC 
Per https://bugzilla.redhat.com/show_bug.cgi?id=1561989#c55, tested this bug on web. Issue fixed and pod with private docker.io image can be running. Moving to VERIFIED