Bug 1568367
| Summary: | Use environment files for setting/unsetting heat resources during major upgrade, minor update and ffwd-upgrade | ||
|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | Marios Andreou <mandreou> |
| Component: | openstack-tripleo-heat-templates | Assignee: | Marios Andreou <mandreou> |
| Status: | CLOSED ERRATA | QA Contact: | Marius Cornea <mcornea> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 13.0 (Queens) | CC: | ccamacho, jschluet, jstransk, mbracho, mburns, mcornea, rhel-osp-director-maint |
| Target Milestone: | beta | Keywords: | Triaged |
| Target Release: | 13.0 (Queens) | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Fixed In Version: | openstack-tripleo-heat-templates-8.0.2-0.20180416194360.29a5ad5.el7ost python-tripleoclient-9.2.0-5.el7ost | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-06-27 13:51:11 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
*** Bug 1568548 has been marked as a duplicate of this bug. *** Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2018:2086 |
Description of problem: For OSP13 all the upgrades related clis ("openstack overcloud upgrade", "openstack overcloud update", "openstack overcloud ffwd-upgrade") have a 'prepare' subcommand where we generate ansible playbooks with a heat stack update. During this stack update we 'noop' the deployment config since we don't want config applied during this step. This is achieved with [1] to set and [2] to unset. Doing this is not scalable as we now have to add more resources for no-op specific to the ffwd-upgrade cli. Furthermore we would also have to deal with unset of resources used during the major upgrade, such as the UpgradeInitCommand. Instead we should use environment files specific to each operation and which will be inserted into the heat call by the tripleoclient. [1] https://github.com/openstack/tripleo-common/blob/6090d32b516f92837fc8b01b7a55dc97ed3e8a77/tripleo_common/actions/package_update.py#L62-L76 [2] https://github.com/openstack/tripleo-common/blob/6090d32b516f92837fc8b01b7a55dc97ed3e8a77/tripleo_common/actions/plan.py#L492-L502