Bug 1571283

Summary:	[RFE] Include virt-admin in RHV-H optional channel so libvirt logging levels can be changed on the fly
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Olimp Bockowski <obockows>
Component:	redhat-virtualization-host	Assignee:	Nir Levy <nlevy>
Status:	CLOSED ERRATA	QA Contact:	shiyi lei <shlei>
Severity:	medium	Docs Contact:
Priority:	low
Version:	4.1.9	CC:	cshao, dfediuck, gveitmic, huzhao, jcoscia, jsuchane, mkalinin, mtessun, nashok, nlevy, obockows, qiyuan, rhodain, shlei, weiwang, yaniwang, ycui
Target Milestone:	ovirt-4.3.2	Keywords:	FutureFeature, Reopened
Target Release:	4.3.0
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:	Previously, changing log levels required editing libvirt.conf and restarting the libvirtd service. This restart prevented support from collecting data and made reproducing issues more difficult. The current release adds the libvirt-admin package to the optional channel for Red Hat Virtualization Host. Installing this package enables you to run the virt-admin command to change libvirt logging levels on the fly.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-11-14 10:03:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Node	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1653669

Description Olimp Bockowski 2018-04-24 12:45:56 UTC

Description of problem:

include a libvirt-admin package by default, it would provide virt-admin command

Version-Release number of selected component (if applicable):

RHV 4.x

How reproducible:

n/a

Steps to Reproduce:

na/a

Actual results:

not present

Expected results:

it is included by default 

Additional info:
More details and why it is needed in following KCS article:
https://access.redhat.com/solutions/53568

Comment 1 cshao 2018-06-12 10:10:38 UTC

QE will check whether RHVH include libvirt-admin package by default.

Comment 2 Ryan Barry 2018-09-05 09:58:42 UTC

*** Bug 1625461 has been marked as a duplicate of this bug. ***

Comment 3 Martin Tessun 2018-09-18 09:29:35 UTC

Hi Olimp,

as we want to keep the footprint of the RHV-H Image as small as possible, I would like to know, why virt-admin is needed here.

So is there a business or technical justification that the customer can't do the following instead:

- edit libvirt.conf directly if needed

Reason: libvirt.conf debug levels should only be adjusted by advice from CE&E anyways. If the instruction is changing the libvirt.conf and restarting libvirt is fine, there is no reason for adding any further stuff to the RHV-H image.

Thanks!
Martin

Comment 4 Roman Hodain 2018-10-01 12:07:21 UTC

(In reply to Martin Tessun from comment #3)
> Hi Olimp,
> 
> as we want to keep the footprint of the RHV-H Image as small as possible, I
> would like to know, why virt-admin is needed here.
> 
> So is there a business or technical justification that the customer can't do
> the following instead:
> 
> - edit libvirt.conf directly if needed
> 
> Reason: libvirt.conf debug levels should only be adjusted by advice from
> CE&E anyways. If the instruction is changing the libvirt.conf and restarting
> libvirt is fine, there is no reason for adding any further stuff to the
> RHV-H image.
> 
> Thanks!
> Martin

The log level changed by the configuration file can only be enabled by restarting the libvirtd service. The restart prevents support from collecting the right data as the state of the libvirt daemon changes and the issue may not appear any more. In some cases, the issue can be reproduced, but reproducing issues on libvirt daemon can be harmful to the system and can take a considerable amount of time. The virt-admin tool allows us to adjust us the log level on the fly. This is a significant advantage for support and consequently for the users.

I believe that this package is must in the image.

Comment 5 Martin Tessun 2018-10-18 09:38:40 UTC

Thanks Roman,

makes sense to me. Approving from supportability and debug perspective.

Comment 6 Yuval Turgeman 2018-12-18 14:14:08 UTC

Nir, please sync with Aviv on this as well, should be similar to bz 1580322

Comment 7 Martin Tessun 2019-01-15 09:25:51 UTC

Hi Jarda,

do we have any possibility setting libvirt loglevel without using virt-admin and without restarting libvirt?

Comment 8 Sandro Bonazzola 2019-01-21 08:31:16 UTC

re-targeting to 4.3.1 since this BZ has not been proposed as blocker for 4.3.0.
If you think this bug should block 4.3.0 please re-target and set blocker flag.

Comment 10 Jaroslav Suchanek 2019-01-28 13:53:35 UTC

(In reply to Martin Tessun from comment #7)
> Hi Jarda,
> 
> do we have any possibility setting libvirt loglevel without using virt-admin
> and without restarting libvirt?

Nope. virt-admin API is the solution you need for that.

Comment 13 Wei Wang 2019-02-17 00:34:01 UTC

Test Version
RHVH-4.3-20190201.0-RHVH-x86_64-dvd1.iso
cockpit-system-176-4.el7.noarch
cockpit-ws-176-4.el7.x86_64
cockpit-bridge-176-4.el7.x86_64
cockpit-storaged-176-4.el7.noarch
cockpit-ovirt-dashboard-0.12.1-1.el7ev.noarch
cockpit-machines-ovirt-176-4.el7.noarch
cockpit-176-4.el7.x86_64
cockpit-dashboard-176-4.el7.x86_64
ovirt-hosted-engine-setup-2.3.3-1.el7ev.noarch
ovirt-hosted-engine-ha-2.3.1-1.el7ev.noarch

Test Steps:
1. Clean install RHVH-4.3-20190201.0-RHVH-x86_64-dvd1.iso
2. Subscribe to stage CDN
3. Enable rhel-7-server-rhvh-4* repos
4. yum search virt-admin

Result:

"No matches found" virt-admin package not in RHVH optional channel.

Moreinfo:
RHVH doesn't include libvirt-admin package by default.

Change ON_QA to "ASSIGNED"

Comment 14 Sandro Bonazzola 2019-02-18 07:57:58 UTC

Moving to 4.3.2 not being identified as blocker for 4.3.1

Comment 15 Nir Levy 2019-03-04 11:30:48 UTC

Tested on RHVH-4.3-20190226.0-RHVH-x86_64-dvd1.iso
Verified.
hannel:https://cdn.stage.redhat.com/content/dist/rhel/server/7/7Server/$basearch/rhvh/4/os

Comment 16 Wei Wang 2019-03-05 02:46:53 UTC

Test Version
rhvh-4.3.0.5-0.20190225.0+1
subscription-manager-1.21.10-3.el7_6.x86_64

Test Steps:
According to comment 13

Result:
Libvirt-admin package exists in RHVH optional channel.


Bug is fixed, change status to "VERIFIED"

Comment 20 errata-xmlrpc 2019-05-08 12:32:16 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:1053

Comment 25 nijin ashok 2019-11-13 10:43:49 UTC

Re-opening this because I can't see any rhvh repo which has libvirt-admin package. Could you please let us know which repo should be having this package? I can't see it in any of the "rhel-7-server-rhvh-4*" repos.

Comment 26 shiyi lei 2019-11-14 06:32:30 UTC

Test Version:
rhvh-4.3.6.5-0.20191108.0

Test Steps:
1. Install rhvh-4.3.6.5-0.20191108.0
2. #rpm -qa|grep virt-admin
3. run command #virt-admin

Test Result:
1.the package info displayed as below:
libvirt-admin-4.5.0-23.el7_7.1.x86_64

2.and command 'virt-admin' is avaliable to use.

libvirt-admin had been included in the image of rhvh-4.3.6.5-0.20191108.0

May I ask in which version of rhvh you want to test? Because I used the latest version and the libvirt-admin package was pre-installed.

Comment 27 nijin ashok 2019-11-14 10:03:14 UTC

Sorry, I was checking the older version and was checking if the repo has it. I can confirm that the latest version has virt-admin. Closing it again. Sorry for confusion.