Bug 157913

Summary: [PATCH] unable a delete a composed indic character in a single keypress
Product: [Fedora] Fedora Reporter: Lawrence Lim <llim>
Component: firefoxAssignee: Christopher Aillon <caillon>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eng-i18n-bugs, jnansi, mcepl, mcepl, petersen, smaitra, tagoh, tools-bugs, wtogami
Target Milestone: ---Keywords: i18n
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: FF3RawhideClose
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-12-20 16:47:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 142699    
Bug Blocks:    
Attachments:
Description Flags
proposed patch none

Description Lawrence Lim 2005-05-17 01:32:59 UTC
+++ This bug was initially created as a clone of Bug #142699 +++

Description of problem:
Further to bug 138661, during editing the delete key does not delete the whole
composed character (unlike gtk+ applications like gedit).

How reproducible:
ALways

Steps to Reproduce:
1. load
http://bob.brisbane.redhat.com/eng/indic/hindi/BrowserTest_Hindi.html
2. go to text box area
3. try to delete an indic character by using BackSpace
  
Actual results:
Unable to delete the whole char with a single BackSpace

Expected results:
Able to delete the whole char using a single BackSpace

Additional info:

Comment 1 Lawrence Lim 2005-05-17 01:34:47 UTC
Updating the description to reflect the current behaviour of gtk+.

Description of problem:
Further to bug 138661, during editing, the 'Delete' key does not delete the whole
composed character (unlike gtk+ applications like gedit).

How reproducible:
ALways

Steps to Reproduce:
1. load
http://bob.brisbane.redhat.com/eng/indic/hindi/BrowserTest_Hindi.html
2. go to text box area
3. try to delete an indic character by using  the 'Delete' key
 
Actual results:
Unable to delete the whole char with a single 'Delete' keypress

Expected results:
Able to delete the whole char using a single 'Delete' keypress

Additional info:
In gtk apps, Delete removes the whole composed character in one keypress while
Backspace remove the charcters which made up of the composed character one at a
time.


Comment 2 Akira TAGOH 2006-08-17 09:06:37 UTC
Created attachment 134372 [details]
proposed patch

attached a patch to fix this issue. I've tested the above URL on firefix with
this patch. and the deletion works fine.

Comment 3 Christopher Blizzard 2006-08-17 12:55:59 UTC
I'm not positive but you should also make sure that there's not an html editor
equivelent problem.  That's used for midas (the HTML rich editor component) and
the HTML editor used in thunderbird.  Once again, not sure if they are different
components entirely or if they work today, but it's worth looking into.

Comment 4 Akira TAGOH 2006-08-17 13:14:07 UTC
Sure. you're right. I think there are a class for HTML editor. I'll look into
this too. thanks for letting me know.

Comment 5 Akira TAGOH 2006-08-17 13:49:50 UTC
just for updates, it also works on midas demo page at least
(http://www.mozilla.org/editor/midasdemo/). is this what you told, right?

BTW this problem still appears on thunderbird as expected unfortunately. but it
should be filed separately IMHO.


Comment 6 Akira TAGOH 2006-08-18 05:32:06 UTC
filed a bug for thunderbird as Bug#203060.

Comment 7 Akira TAGOH 2006-08-18 08:49:55 UTC
ah, ok. thunderbird just needs the same patch to fix the same problem. no need
to apply any patches futhermore.

Comment 8 Akira TAGOH 2006-09-04 03:26:06 UTC
*** Bug 204932 has been marked as a duplicate of this bug. ***

Comment 9 Christopher Aillon 2006-09-15 02:48:31 UTC
Upstream seems to imply the patch needs work, see
http://bugzilla.mozilla.org/show_bug.cgi?id=348838

Need patches to be generally accepted upstream before we can add them to our RPMs.

Comment 10 Matthias Clasen 2006-09-15 19:13:06 UTC
Given the "must be upstream first" policy for mozilla patches, these bugs can't
block FC6

Comment 11 Satyabrata Maitra 2007-12-11 12:20:30 UTC
The same bug found in FC8 released version as well.

version  of the component tested :-
firefox-2.0.0.8-2.fc8

Delete key is not deleting the whole composed char in a single key press.
(When use delete key, the cursor should be placed on the left hand side of the
composed char, and tested in this way infact)

Comment 12 Matěj Cepl 2007-12-20 16:47:13 UTC
We just updated the Firefox version in Fedora/development from 2.0 to a 3.0
pre-release version, which improves performance, memory usage, and fixes many
bugs and crashes.

Closing as CANTFIX since we aren't fixing bugs filed against 2.0 now that 3.0 is
in.  If this bug is still present in rawhide using a Firefox 3.0 version, please
re-open this bug.

Thanks and Happy Holidays

Comment 13 Parag Nemade 2008-04-10 06:15:55 UTC
Tested this with firefox-3.0-0.53.beta5.fc9.i386 rawhide rpm today. Found this
is resolved.
Current behaviour in Firefox is like this
composed character can be deleted in single "delete" keypress
composed character can be modified in multiple "backspace" keypress or deleted
in multiple "delete" keypress.

This is exactly same behaviour as tested using gedit(gtk application)