Bug 1632397

Summary:	ASB gets installed during upgrade even though ansible_service_broker_install is set to true.
Product:	OpenShift Container Platform	Reporter:	Ryan Howe <rhowe>
Component:	Cluster Version Operator	Assignee:	Jeremiah Stuever <jstuever>
Status:	CLOSED ERRATA	QA Contact:	Weihua Meng <wmeng>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.10.0	CC:	aleks, aos-bugs, jiajliu, jokerman, jstuever, mmccomas, wmeng, wsun
Target Milestone:	---	Keywords:	Triaged
Target Release:	3.10.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1640497 1640498 (view as bug list)		Environment:
Last Closed:	2019-01-10 09:27:10 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ryan Howe 2018-09-24 17:02:04 UTC

Description of problem:

 ASB gets installed during upgrade even though ansible_service_broker_install is set to true. 


Version-Release number of selected component (if applicable):
3.10

How reproducible:
100%

Steps to Reproduce:
1. Install 3.9 cluster with ansible_service_broker_install=false
2. Upgrade to 3.10 with ansible_service_broker_install=false

Actual results:
ASB gets installed 


Expected results:
Skip installing ASB


Additional info:
For upgrades the conditional is used openshift_enable_service_catalog=true, when deciding to install the ASB 

```
   https://github.com/openshift/openshift-ansible/blob/master/playbooks/common/openshift-cluster/upgrades/upgrade_components.yml#L7-L21

  - import_role:
      name: ansible_service_broker
      tasks_from: install.yml
    when:
    - openshift_enable_service_catalog | default(true) | bool
```

For installs the conditional is used looking for ansible_service_broker_install=true.

https://github.com/openshift/openshift-ansible/blob/master/roles/ansible_service_broker/tasks/main.yml

  - include_tasks: install.yml
    when: ansible_service_broker_install | bool

Comment 1 Aleks Lazic 2018-10-10 08:45:25 UTC

We face the same problem at the update from 3.9 -> 3.9.

`ansible_service_broker_install=false` is in the hosts file but the following command want do uodate ansible broker

ansible-playbook -i /tmp/ose-hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_9/upgrade_control_plane.yml

Looks like there is a pull request which fixes this bug.

https://github.com/openshift/openshift-ansible/pull/9770

Any Idea when this fix will be available on 3.9 rpms?

Comment 2 Weihua Meng 2018-10-22 07:00:30 UTC

test case added.

Comment 4 Jeremiah Stuever 2018-11-21 16:09:49 UTC

https://github.com/openshift/openshift-ansible/pull/10678

Comment 5 Weihua Meng 2018-11-22 06:19:32 UTC

Fixed.

openshift-ansible-3.10.79-1.git.0.10daf7d.el7.noarch

Kernel Version: 3.10.0-957.el7.x86_64
Operating System: Red Hat Enterprise Linux Server 7.6 (Maipo)

Comment 7 errata-xmlrpc 2019-01-10 09:27:10 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0026