Bug 1632901

Summary: Tags responding to `show` with true and having no classification produce 500-level errors for URL of `/api/tags?expand=resources&attributes=category,categorization`
Product: Red Hat CloudForms Management Engine Reporter: Robb Manes <rmanes>
Component: ApplianceAssignee: Julian Cheal <jcheal>
Status: CLOSED CURRENTRELEASE QA Contact: Parthvi Vala <pvala>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.9.4CC: abellott, dmetzger, gtanzill, hkataria, ikaur, jcheal, jocarter, jprause, lavenel, mpovolny, obarenbo, pvala, saali, simaishi, yrudman
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.10.0.24 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1648948 (view as bug list) Environment:
Last Closed: 2019-02-12 16:50:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1648948    

Comment 6 Julian Cheal 2018-11-08 18:27:16 UTC
PR for this BZ https://github.com/ManageIQ/manageiq/pull/18177

Comment 8 CFME Bot 2018-11-12 16:06:05 UTC
New commit detected on ManageIQ/manageiq/hammer:

https://github.com/ManageIQ/manageiq/commit/bac84088f5b756e7d136dd8746612defa93c3487
commit bac84088f5b756e7d136dd8746612defa93c3487
Author:     Gregg Tanzillo <gtanzill>
AuthorDate: Fri Nov  9 13:35:27 2018 -0500
Commit:     Gregg Tanzillo <gtanzill>
CommitDate: Fri Nov  9 13:35:27 2018 -0500

    Merge pull request #18177 from juliancheal/fix_tags_without_classifications_errors

    Tags without a classification cause errors

    (cherry picked from commit 3217a89bb0d0c76d7a482eada25e93e4f35ae2f4)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1632901

 app/models/tag.rb | 8 +-
 spec/models/tag_spec.rb | 12 +
 2 files changed, 16 insertions(+), 4 deletions(-)

Comment 10 Parthvi Vala 2018-11-26 16:48:56 UTC
FIXED. Verified on 5.10.0.25.20181120211723_d2fd659.

Steps taken to verify:
1) Create a category and tag.
2) SSH into appliance, `vmdb`, and `bin/rails c`.
3) Get the required tag with: 
        tag = Tag.find_by(name: "/managed/cat_1/tag_1")
4) Delete the classification associated with tag.
        tag.classification.delete
5) Send a request. 
GET /api/tags?expand=resources&attributes=category,categorization


There was no internal server error or any error in the API log, unlike the version in which this BZ was released(5.9.4.7).

Comment 11 Gregg Tanzillo 2018-12-04 22:45:37 UTC
*** Bug 1656182 has been marked as a duplicate of this bug. ***

Comment 12 Gregg Tanzillo 2018-12-19 16:32:50 UTC
*** Bug 1649245 has been marked as a duplicate of this bug. ***