Bug 1648296

Summary:	dht_revalidate may not heal attrs on the brick root
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Nithya Balachandran <nbalacha>
Component:	distribute	Assignee:	Nithya Balachandran <nbalacha>
Status:	CLOSED ERRATA	QA Contact:	Sayalee <saraut>
Severity:	high	Docs Contact:
Priority:	high
Version:	rhgs-3.4	CC:	nbalacha, rhs-bugs, sankarshan, saraut, sheggodu, spalai, storage-qa-internal
Target Milestone:	---	Keywords:	Triaged, ZStream
Target Release:	RHGS 3.4.z Batch Update 3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.12.2-33	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1648298 (view as bug list)		Environment:
Last Closed:	2019-02-04 07:41:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1648298, 1660736, 1693057
Bug Blocks:

Description Nithya Balachandran 2018-11-09 10:58:01 UTC

Description of problem:


In dht_revalidate_cbk, the stbuf returned by the brick is merged into local->stbuf only if the dir contains a layout. local->stbuf is also used to compare the stbuf returned in responses to check if an attr heal is needed.

If the newly added brick (which does not contain a layout) is the first one to respond, its stbuf is not merged into local->stbuf. Subsequent responses from existing bricks never see a mismatch in the stbuf and self heal is not triggered.

https://gluster-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/periodic-regression/668/console

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Sunil Kumar Acharya 2018-11-16 10:00:17 UTC

Upstream Patch: https://review.gluster.org/#/c/glusterfs/+/21611/

Comment 18 Sayalee 2019-01-09 12:30:03 UTC

Tested the issue as per the test plan shared in #comment8, and could not reproduce the issue with the current release(3.12.2-36 build). 
So after discussing with Nag and based on the discussion in #comment17, moving this bug to verified.

Comment 20 errata-xmlrpc 2019-02-04 07:41:26 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0263