Bug 1653634
| Summary: | Review Request: golang-github-mdlayher-raw - Package raw enables reading and writing data at the device driver level for a network interface | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marek Skalický <mskalick> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, jchaloup, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-12-03 11:36:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1653635 | ||
|
Description
Marek Skalický
2018-11-27 10:27:02 UTC
- Missing BuildRequires in the devel package: BuildRequires: golang(github.com/google/go-cmp/cmp) BuildRequires: golang(golang.org/x/net/bpf) BuildRequires: golang(golang.org/x/sys/unix) - you can remove all the with_bundled pieces unless there is no other way than to built the project from vendored deps Please provide koji scratch build. Spec URL: https://mskalick.fedorapeople.org/reviews/golang-github-mdlayher-raw/golang-github-mdlayher-raw.spec SRPM URL: https://mskalick.fedorapeople.org/reviews/golang-github-mdlayher-raw/golang-github-mdlayher-raw-0-0.2.20181126gitfa5ef33.fc30.src.rpm Description: Package raw enables reading and writing data at the device driver level for a network interface Fedora Account System Username: mskalick Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=31192838 Removed %{with_bundled} (In reply to Jan Chaloupka from comment #1) > - Missing BuildRequires in the devel package: Why is this needed? IMHO BuildRequires: are for the whole spec file, not per sub-package. And I saw them mainly in first part, after SourcesX: ... > Why is this needed?
BR's in the main package are allocated for building binaries. The list of dependencies for building binaries can be different from the list of dependencies of the devel subpackage. Right now it has the same effect. Thought, it's easy to forget about it once you start building binaries. It's up to you.
- License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. Please assign the package to go-sig too so we can do the upkeep. Don't forget to add it to Koschei too. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-mdlayher-raw Thanks for the review. |