Bug 1653635 - Review Request: golang-github-google-gopacket - This library provides packet decoding capabilities for Go
Summary: Review Request: golang-github-google-gopacket - This library provides packet ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1653634
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-11-27 10:28 UTC by Marek Skalický
Modified: 2018-12-03 11:36 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-12-03 11:36:26 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+

Attachments (Terms of Use)

Description Marek Skalický 2018-11-27 10:28:22 UTC 
Spec URL: https://mskalick.fedorapeople.org/reviews/golang-github-google-gopacket/golang-github-google-gopacket.spec
SRPM URL: https://mskalick.fedorapeople.org/reviews/golang-github-google-gopacket/golang-github-google-gopacket-0-0.1.20181126gitec90f6c.fc30.src.rpm
Description: This library provides packet decoding capabilities for Go
Fedora Account System Username: mskalick
Comment 1 Robert-André Mauchin 🐧 2018-11-30 17:48:02 UTC 
  - Use the releases: https://github.com/google/gopacket/releases

%global goipath         github.com/google/gopacket
Version:                1.1.15

%gometa

Name:           %{goname}
Release:        1%{?dist}

 - There's no vendor dir so I don't get the need for the whole !0%{?with_bundled} mechanics

 - Why the tests are disabled? All tests seem to run fine here.
Comment 2 Marek Skalický 2018-11-30 19:57:21 UTC 
Spec URL: https://mskalick.fedorapeople.org/reviews/golang-github-google-gopacket/golang-github-google-gopacket.spec
SRPM URL: https://mskalick.fedorapeople.org/reviews/golang-github-google-gopacket/golang-github-google-gopacket-1.1.15-1.fc30.src.rpm
Description: This library provides packet decoding capabilities for Go
Fedora Account System Username: mskalick

All issues fixed.
Comment 3 Robert-André Mauchin 🐧 2018-11-30 20:58:29 UTC 
Package approved.
Comment 4 Gwyn Ciesla 2018-11-30 21:31:28 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-google-gopacket
Comment 5 Marek Skalický 2018-12-03 11:36:26 UTC 
Thanks for the review.
Note You need to log in before you can comment on or make changes to this bug.