- Missing BuildRequires in the devel package:

BuildRequires: golang(github.com/google/go-cmp/cmp)
BuildRequires: golang(golang.org/x/net/bpf)
BuildRequires: golang(golang.org/x/sys/unix)

- you can remove all the with_bundled pieces unless there is no other way than to built the project from vendored deps

Please provide koji scratch build.

Spec URL: https://mskalick.fedorapeople.org/reviews/golang-github-mdlayher-raw/golang-github-mdlayher-raw.spec
SRPM URL: https://mskalick.fedorapeople.org/reviews/golang-github-mdlayher-raw/golang-github-mdlayher-raw-0-0.2.20181126gitfa5ef33.fc30.src.rpm
Description: Package raw enables reading and writing data at the device driver level for a network interface
Fedora Account System Username: mskalick


Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=31192838

Removed %{with_bundled}

(In reply to Jan Chaloupka from comment #1)
> - Missing BuildRequires in the devel package:

Why is this needed?

IMHO BuildRequires: are for the whole spec file, not per sub-package. And I saw them mainly in first part, after SourcesX: ...

> Why is this needed?

BR's in the main package are allocated for building binaries. The list of dependencies for building binaries can be different from the list of dependencies of the devel subpackage. Right now it has the same effect. Thought, it's easy to forget about it once you start building binaries. It's up to you.

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines


Package approved.


Please assign the package to go-sig too so we can do the upkeep. Don't forget to add it to Koschei too.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-mdlayher-raw

Thanks for the review.