Bug 166186

Summary: Review Request: perl-Class-DBI-AsForm : Produce HTML form elements for database columns
Product: [Fedora] Fedora Reporter: Tom "spot" Callaway <tcallawa>
Component: Package ReviewAssignee: Paul Howarth <paul>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://search.cpan.org/dist/Class-DBI-AsForm
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-09-08 15:41:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 166184, 166194    
Bug Blocks: 163779, 166203    

Description Tom "spot" Callaway 2005-08-17 20:21:39 UTC 
Spec Name or Url: 
http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-AsForm.spec

SRPM Name or Url: 
http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-AsForm-2.41-2.src.rpm

Description: 

Produce HTML form elements for database columns.

(NOTE: This package is one of the Maypole dependencies)
Comment 1 Tom "spot" Callaway 2005-09-07 19:38:01 UTC 
Cleaned up based on other Maypole fixes:

New SPEC:
http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-AsForm.spec

New SRPM:
http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-AsForm-2.41-3.src.rpm
Comment 2 Paul Howarth 2005-09-08 11:48:06 UTC 
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec, text included
- spec written in English and is legible
- sources match upstream
- package builds OK in FC4 and in mock for rawhide (i386)
- BRs OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets

Nitpick:

- I think the README contains better text for use as %description, rather than
  simply repeating %summary:

    This module helps to generate HTML forms for creating new database rows
    or editing existing rows. It maps column names in a database table to
    HTML form elements that fit the schema. Large text fields are turned
    into textareas, and fields with a has-a relationship to other
    "Class::DBI" tables are turned into select drop-downs populated with
    objects from the joined class.

Approved.