Spec Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-AsForm.spec SRPM Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-AsForm-2.41-2.src.rpm Description: Produce HTML form elements for database columns. (NOTE: This package is one of the Maypole dependencies)
Cleaned up based on other Maypole fixes: New SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-AsForm.spec New SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-AsForm-2.41-3.src.rpm
Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, matches spec, text included - spec written in English and is legible - sources match upstream - package builds OK in FC4 and in mock for rawhide (i386) - BRs OK - no locales, libraries, subpackages or pkgconfigs to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets Nitpick: - I think the README contains better text for use as %description, rather than simply repeating %summary: This module helps to generate HTML forms for creating new database rows or editing existing rows. It maps column names in a database table to HTML form elements that fit the schema. Large text fields are turned into textareas, and fields with a has-a relationship to other "Class::DBI" tables are turned into select drop-downs populated with objects from the joined class. Approved.