Spec Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Plugin-Type.spec SRPM Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Plugin-Type-0.02-2.src.rpm Description: Determine type information for columns (NOTE: This package is one of the Maypole dependencies)
Review: - rpmlint clean - package and spec file naming OK - package meets guidelines - license is same as perl, matches spec - spec written in English and legible - source matches upstream - builds OK in mock for FC4 (i386) - BR's mostly OK - no locales, libraries, subpackages, pkgconfigs etc. to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets Needswork: - redundant BR: perl - BR: perl(DBD::SQLite) needed for %check - license text not included Nitpick: - suggest using %{?_smp_mflags} with make in %%build
Created attachment 118290 [details] Patch addressing review issues
Changes made in -3. New SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Plugin-Type-0.02-3.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Plugin-Type.spec
Approved.