This service will be undergoing maintenance at 20:00 UTC, 2017-04-03. It is expected to last about 30 minutes
Bug 166194 - Review Request: perl-Class-DBI-Plugin-Type : Determine type information for columns
Review Request: perl-Class-DBI-Plugin-Type : Determine type information for c...
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Paul Howarth
David Lawrence
Depends On: 166192
Blocks: FE-ACCEPT 166186
  Show dependency treegraph
Reported: 2005-08-17 16:39 EDT by Tom "spot" Callaway
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2005-09-01 17:12:41 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Patch addressing review issues (1.50 KB, patch)
2005-08-31 06:53 EDT, Paul Howarth
no flags Details | Diff

  None (edit)
Description Tom "spot" Callaway 2005-08-17 16:39:28 EDT
Spec Name or Url:

SRPM Name or Url:


Determine type information for columns

(NOTE: This package is one of the Maypole dependencies)
Comment 1 Paul Howarth 2005-08-31 06:46:23 EDT

- rpmlint clean
- package and spec file naming OK
- package meets guidelines
- license is same as perl, matches spec
- spec written in English and legible
- source matches upstream
- builds OK in mock for FC4 (i386)
- BR's mostly OK
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets


- redundant BR: perl
- BR: perl(DBD::SQLite) needed for %check
- license text not included


- suggest using %{?_smp_mflags} with make in %%build
Comment 2 Paul Howarth 2005-08-31 06:53:27 EDT
Created attachment 118290 [details]
Patch addressing review issues
Comment 4 Paul Howarth 2005-09-01 11:33:05 EDT

Note You need to log in before you can comment on or make changes to this bug.