| Summary: | Review Request: perl-Class-DBI-Loader : Dynamic definition of Class::DBI sub classes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> | ||||
| Component: | Package Review | Assignee: | Paul Howarth <paul> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | http://search.cpan.org/dist/Class-DBI-Loader/ | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2005-09-14 18:40:57 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | ||||||
| Bug Depends On: | 166184, 166191, 166195, 166196 | ||||||
| Bug Blocks: | 163779, 166189 | ||||||
| Attachments: |
|
||||||
|
Description
Tom "spot" Callaway
2005-08-17 20:29:33 UTC
Cleaned up based on other Maypole fixes: New SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Loader.spec New SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Loader-0.22-3.src.rpm Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, matches spec, text included - spec file written in English and is legible - sources match upstream - package builds OK in mock on FC4 (i386) - BR's mostly OK - no locales, libraries, subpackages or pkgconfigs to worry about - not relocatable - no directory ownership or permissions problems - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets - no desktop file needed Suggestions: - POD checks are skipped by default - they can be enabled by setting the TEST_POD environment variable - Having enabled POD checks, you'll then need to disable the POD coverage check because it fails - Additional BR: perl(Test::Pod) is needed for the POD check - BR: perl(Class::DBI) isn't needed because it's pulled in by the other BR's that are derived from that class - Explicit perl(Class::DBI) dep isn't needed because it's pulled in by the other auto-detected deps (e.g. perl(Class::DBI::SQLite)) Approved since these aren't blockers. Created attachment 118628 [details]
Patch addressing review issues
|