Bug 1665452

Summary:	[OSP13] fixed_key value is logged in the cinder logs
Product:	Red Hat OpenStack	Reporter:	Sofia Enriquez <senrique>
Component:	openstack-cinder	Assignee:	Cinder Bugs List <cinder-bugs>
Status:	CLOSED ERRATA	QA Contact:	Tzach Shefi <tshefi>
Severity:	high	Docs Contact:	Tana <tberry>
Priority:	medium
Version:	13.0 (Queens)	CC:	abishop, dhill, eharney, knylande, tshefi, tvignaud
Target Milestone:	---	Keywords:	Triaged, ZStream
Target Release:	13.0 (Queens)
Hardware:	Unspecified
OS:	All
Whiteboard:
Fixed In Version:	openstack-cinder-12.0.4-8.el7ost	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1655742	Environment:
Last Closed:	2019-03-14 13:47:53 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1665456
Bug Blocks:	1655742

Description Sofia Enriquez 2019-01-11 13:15:45 UTC

+++ This bug was initially created as a clone of Bug #1655742 +++

Description of problem:
fixed_key value is logged in the cinder logs

How reproducible:
Always

Steps to Reproduce:
1. Set fixed_key value

Actual results:
It's logged in the logs

Expected results:
It shouldn't be logged

Additional info:

This appears to be an OSP10 z8 regression introduced by bug 1547600.

The code in OSP10 used to detect which values to mask by looking for "_key" in the config option name, but this was changed to fix another similar issue.

Comment 2 Tzach Shefi 2019-03-12 12:17:23 UTC

Verified on:
openstack-cinder-12.0.4-8.el7ost.noarch

Set fixed_key on cinder.conf
restarted docker
The key isn't listed any more (*****) on c-vol log file. 
 

2019-03-12 11:56:55.152 1 DEBUG oslo_service.service [req-8d5b2b9a-f190-43a4-8e08-e6bb528dabfe - - - - -] key_manager.fixed_key          = **** log_opt_values /usr/lib/python2.7/site-pack

Comment 4 errata-xmlrpc 2019-03-14 13:47:53 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0560