Bug 1665456 - [OSP14] fixed_key value is logged in the cinder logs
Summary: [OSP14] fixed_key value is logged in the cinder logs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-cinder
Version: 14.0 (Rocky)
Hardware: Unspecified
OS: All
medium
high
Target Milestone: ---
: 14.0 (Rocky)
Assignee: Sofia Enriquez
QA Contact: Tzach Shefi
Tana
URL:
Whiteboard:
Depends On:
Blocks: 1655742 1665452
TreeView+ depends on / blocked
 
Reported: 2019-01-11 13:24 UTC by Sofia Enriquez
Modified: 2019-03-18 12:56 UTC (History)
6 users (show)

Fixed In Version: openstack-cinder-13.0.3-0.20190118014305.44c5314.el7ost
Doc Type: Bug Fix
Doc Text:
Cause: The code in OSP10 used to detect which values to mask by looking for "_key" in the config option name, but this was changed to fix another similar issue. Consequence: fixed_key value is logged in the cinder logs. Fix: Add secret=true to fixed_key configuration parameter as that value shouldn't be logged. Result: fixed_key value isn't logged anymore.
Clone Of: 1655742
Environment:
Last Closed: 2019-03-18 12:56:24 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenStack gerrit 625139 0 None None None 2019-01-11 13:29:57 UTC
Red Hat Product Errata RHBA-2019:0586 0 None None None 2019-03-18 12:56:29 UTC

Description Sofia Enriquez 2019-01-11 13:24:41 UTC
+++ This bug was initially created as a clone of Bug #1655742 +++

Description of problem:
fixed_key value is logged in the cinder logs

How reproducible:
Always

Steps to Reproduce:
1. Set fixed_key value

Actual results:
It's logged in the logs

Expected results:
It shouldn't be logged

Additional info:

This appears to be an OSP10 z8 regression introduced by bug 1547600.

The code in OSP10 used to detect which values to mask by looking for "_key" in the config option name, but this was changed to fix another similar issue.

Comment 3 Tzach Shefi 2019-03-12 12:27:51 UTC
Verified on:
openstack-cinder-13.0.3-0.20190118014305.44c5314.el7ost.noarch

Set fixed_key, restarted docker
We don't see the key (***) in log 


DEBUG oslo_service.service [req-f8de6475-36f0-4995-9710-6be06822d958 - - - - -] key_manager.fixed_key          = **** log_opt_values

Comment 6 errata-xmlrpc 2019-03-18 12:56:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0586


Note You need to log in before you can comment on or make changes to this bug.