Bug 1665452 - [OSP13] fixed_key value is logged in the cinder logs
Summary: [OSP13] fixed_key value is logged in the cinder logs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-cinder
Version: 13.0 (Queens)
Hardware: Unspecified
OS: All
medium
high
Target Milestone: ---
: 13.0 (Queens)
Assignee: Cinder Bugs List
QA Contact: Tzach Shefi
Tana
URL:
Whiteboard:
Depends On: 1665456
Blocks: 1655742
TreeView+ depends on / blocked
 
Reported: 2019-01-11 13:15 UTC by Sofia Enriquez
Modified: 2019-03-14 13:47 UTC (History)
6 users (show)

Fixed In Version: openstack-cinder-12.0.4-8.el7ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1655742
Environment:
Last Closed: 2019-03-14 13:47:53 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenStack gerrit 625140 0 None stable/queens: MERGED cinder: Add secret=true to fixed_key configuration parameter (I21e1246769213fb7b9e283c0ed3a369cbe780650) 2019-03-08 16:51:14 UTC
Red Hat Product Errata RHBA-2019:0560 0 None None None 2019-03-14 13:47:55 UTC

Description Sofia Enriquez 2019-01-11 13:15:45 UTC
+++ This bug was initially created as a clone of Bug #1655742 +++

Description of problem:
fixed_key value is logged in the cinder logs

How reproducible:
Always

Steps to Reproduce:
1. Set fixed_key value

Actual results:
It's logged in the logs

Expected results:
It shouldn't be logged

Additional info:

This appears to be an OSP10 z8 regression introduced by bug 1547600.

The code in OSP10 used to detect which values to mask by looking for "_key" in the config option name, but this was changed to fix another similar issue.

Comment 2 Tzach Shefi 2019-03-12 12:17:23 UTC
Verified on:
openstack-cinder-12.0.4-8.el7ost.noarch

Set fixed_key on cinder.conf
restarted docker
The key isn't listed any more (*****) on c-vol log file. 
 

2019-03-12 11:56:55.152 1 DEBUG oslo_service.service [req-8d5b2b9a-f190-43a4-8e08-e6bb528dabfe - - - - -] key_manager.fixed_key          = **** log_opt_values /usr/lib/python2.7/site-pack

Comment 4 errata-xmlrpc 2019-03-14 13:47:53 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0560


Note You need to log in before you can comment on or make changes to this bug.