Bug 166924

Summary: Review Request: scim-skk
Product: [Fedora] Fedora Reporter: Ryo Dairiki <ryo-dairiki>
Component: Package ReviewAssignee: Jens Petersen <petersen>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-extras-list
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://scim-imengine.sourceforge.jp/
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-09-19 01:12:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779, 167798    
Attachments:
Description Flags
review1.patch
none
review2.patch none

Description Ryo Dairiki 2005-08-28 00:29:40 UTC 
Spec Name or Url: http://proxy.f2.ymdb.yahoofs.jp/users/d1e4801f/bc/scim-skk/scim-skk.spec?bct_6hDB3qAVldL_
SRPM Name or Url: http://proxy.f2.ymdb.yahoofs.jp/users/d1e4801f/bc/scim-skk/scim-skk-0.3.0-2.src.rpm?bct_6hDBejgcJtjB
Description: Scim-skk is a SCIM IMEngine module for skk to support Japanese input.
Comment 1 Jens Petersen 2005-09-06 12:10:18 UTC 
rpmlint of the srpm gives:

W: scim-skk summary-ended-with-dot SCIM IMEngine module for skk.
E: scim-skk no-changelogname-tag
W: scim-skk strange-permission scim-skk.spec 0666
Comment 2 Jens Petersen 2005-09-06 12:15:43 UTC 
Created attachment 118501 [details]
review1.patch

With this minor patch I think this can be accepted.
Thanks, please go ahead and import into cvs.
Comment 3 Jens Petersen 2005-09-06 12:20:39 UTC 
Created attachment 118502 [details]
review2.patch

Sorry please use this patch.
Comment 4 Jens Petersen 2005-09-13 07:10:02 UTC 
[Please update bugzilla after you have imported.]

Looks like you applied the first patch not the second?
Anyway I think this is good enough, but you may want to merge in the changes
in the second patch if you like.
Comment 5 Ryo Dairiki 2005-09-16 16:06:50 UTC 
Now I've imported your second patch, and updated bugzilla entries.
Thanks.