Bug 166924 - Review Request: scim-skk
Summary: Review Request: scim-skk
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jens Petersen
QA Contact: David Lawrence
URL: http://scim-imengine.sourceforge.jp/
Whiteboard:
Depends On:
Blocks: FE-ACCEPT SCIM
TreeView+ depends on / blocked
 
Reported: 2005-08-28 00:29 UTC by Ryo Dairiki
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-09-19 01:12:04 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
review1.patch (1.25 KB, patch)
2005-09-06 12:15 UTC, Jens Petersen 		no flags Details | Diff
review2.patch (1.91 KB, patch)
2005-09-06 12:20 UTC, Jens Petersen 		no flags Details | Diff
Show Obsolete (1) View All

Description Ryo Dairiki 2005-08-28 00:29:40 UTC 
Spec Name or Url: http://proxy.f2.ymdb.yahoofs.jp/users/d1e4801f/bc/scim-skk/scim-skk.spec?bct_6hDB3qAVldL_
SRPM Name or Url: http://proxy.f2.ymdb.yahoofs.jp/users/d1e4801f/bc/scim-skk/scim-skk-0.3.0-2.src.rpm?bct_6hDBejgcJtjB
Description: Scim-skk is a SCIM IMEngine module for skk to support Japanese input.
Comment 1 Jens Petersen 2005-09-06 12:10:18 UTC 
rpmlint of the srpm gives:

W: scim-skk summary-ended-with-dot SCIM IMEngine module for skk.
E: scim-skk no-changelogname-tag
W: scim-skk strange-permission scim-skk.spec 0666
Comment 2 Jens Petersen 2005-09-06 12:15:43 UTC 
Created attachment 118501 [details]
review1.patch

With this minor patch I think this can be accepted.
Thanks, please go ahead and import into cvs.
Comment 3 Jens Petersen 2005-09-06 12:20:39 UTC 
Created attachment 118502 [details]
review2.patch

Sorry please use this patch.
Comment 4 Jens Petersen 2005-09-13 07:10:02 UTC 
[Please update bugzilla after you have imported.]

Looks like you applied the first patch not the second?
Anyway I think this is good enough, but you may want to merge in the changes
in the second patch if you like.
Comment 5 Ryo Dairiki 2005-09-16 16:06:50 UTC 
Now I've imported your second patch, and updated bugzilla entries.
Thanks.
Note You need to log in before you can comment on or make changes to this bug.