Bug 167377

Summary:	Review Request: perl-Class-Singleton
Product:	[Fedora] Fedora	Reporter:	Steven Pritchard <steve>
Component:	Package Review	Assignee:	Paul Howarth <paul>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://ftp.kspei.com/pub/steve/rpms/perl-Class-Singleton-1.03-1.src.rpm
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-09-08 16:37:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 167376

Description Steven Pritchard 2005-09-02 00:43:41 UTC

Spec Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Class-Singleton/perl-Class-Singleton.spec
SRPM Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Class-Singleton-1.03-1.src.rpm
Description:
This is the Class::Singleton module. A Singleton describes an object
class that can have only one instance in any system. An example of a
Singleton might be a print spooler or system registry. This module
implements a Singleton class from which other classes can be derived.
By itself, the Class::Singleton module does very little other than
manage the instantiation of a single object. In deriving a class from
Class::Singleton, your module will inherit the Singleton instantiation
method and can implement whatever specific functionality is required.

Comment 1 Paul Howarth 2005-09-07 09:55:33 UTC

Review:

- package and spec naming OK
- package meets guidelines
- license is Artistic, matches spec, text included
- spec file written in English and is legible
- source matches upstream
- builds OK in mock for FC4 and rawhide (i386)
- no BRs
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets

Needswork:

- rpmlint not clean:

E: perl-Class-Singleton script-without-shellbang
/usr/lib/perl5/vendor_perl/5.8.6/Class/Singleton.pm
This script does not begins with a shellbang. It will prevent its execution.

This is due to the exec bit being set on Singleton.pm in the upstream tarball,
and this permission is preserved at install-time. It can be fixed by adding
after %setup:

chmod -x Singleton.pm

You can fix that in CVS.

Approved.

Comment 2 Steven Pritchard 2005-09-08 16:37:38 UTC

Fixed in 1.03-2.

Comment 3 Steven Pritchard 2010-12-07 19:55:55 UTC

Package Change Request
======================
Package Name: perl-Class-Singleton
New Branches: el6
Owners: steve
InitialCC: perl-sig

Comment 4 Steven Pritchard 2010-12-08 13:56:53 UTC

Nevermind.  It's in the optional repo.