Red Hat Bugzilla – Bug 167377
Review Request: perl-Class-Singleton
Last modified: 2010-12-08 08:56:53 EST
Spec Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Class-Singleton/perl-Class-Singleton.spec
SRPM Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Class-Singleton-1.03-1.src.rpm
This is the Class::Singleton module. A Singleton describes an object
class that can have only one instance in any system. An example of a
Singleton might be a print spooler or system registry. This module
implements a Singleton class from which other classes can be derived.
By itself, the Class::Singleton module does very little other than
manage the instantiation of a single object. In deriving a class from
Class::Singleton, your module will inherit the Singleton instantiation
method and can implement whatever specific functionality is required.
- package and spec naming OK
- package meets guidelines
- license is Artistic, matches spec, text included
- spec file written in English and is legible
- source matches upstream
- builds OK in mock for FC4 and rawhide (i386)
- no BRs
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets
- rpmlint not clean:
E: perl-Class-Singleton script-without-shellbang
This script does not begins with a shellbang. It will prevent its execution.
This is due to the exec bit being set on Singleton.pm in the upstream tarball,
and this permission is preserved at install-time. It can be fixed by adding
chmod -x Singleton.pm
You can fix that in CVS.
Fixed in 1.03-2.
Package Change Request
Package Name: perl-Class-Singleton
New Branches: el6
Nevermind. It's in the optional repo.