Spec Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-DateTime/perl-DateTime.spec SRPM Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-DateTime-0.2901-1.src.rpm Description: The DateTime.pm module aims to provide a complete, correct, and easy to use date/time object implementation. Currently it handles many date calculations, date math (addition and subtraction), and provides convenient methods for retrieving portions of a date/time. This package is a bit odd. To avoid circular dependencies, I've bundled DateTime, DateTime::Locale, and DateTime::TimeZone.
Well, this was an interesting package. Looking at it, I found a few problems and nit-picks without doing a formal review: - The DateTime tarball was unpacked three times, once when expected and also when the other two tarballs were unpacked - The files list listed some files more than once (since the package contains a mix of arch-specific and arch-independent modules, and %{perl_vendorarch} is included within %{perl_vendorlib}) - The DT::Locale module includes an additional license file - The package wasn't rpmlint clean (complains about having both versioned and unversioned Provides: entries for two of the modules) - The package doesn't build in mock (PERLLIB gets clobbered by the test scripts) I've had a go at fixing all of these issues, and will attach a new spec file to this bug. See what you think.
Created attachment 118893 [details] Spec addressing first-pass issues
Looks good to me. http://ftp.kspei.com/pub/steve/rpms/perl-DateTime/perl-DateTime.spec http://ftp.kspei.com/pub/steve/rpms/perl-DateTime-0.2901-2.src.rpm
Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, matches spec, text included - some files licensed differently (disttributable), additional license included - spec file written in English and is legible - sources match upstream - package builds OK in FC4 and in mock for FC3 and rawhide (i386) - BR's OK - no locales, libraries, subpackages, or pkgconfigs to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no desktop file needed - no scriptlets Approved.
Package Change Request ====================== Package Name: perl-DateTime New Branches: EL-6 Owners: tremble No response from owner, and it's going to be tied to EL-6 SRPMs anyway... https://bugzilla.redhat.com/show_bug.cgi?id=612864
CVS done (by process-cvs-requests.py).