Bug 1674000

Summary:	selinux role: Ansible linux system role for selinux should list all variables in defaults/main.yml
Product:	Red Hat Enterprise Linux 7	Reporter:	Marek Hulan <mhulan>
Component:	rhel-system-roles	Assignee:	Pavel Cahyna <pcahyna>
Status:	CLOSED ERRATA	QA Contact:	David Jež <djez>
Severity:	unspecified	Docs Contact:
Priority:	high
Version:	7.7	CC:	djez, ovasik, tbowling, till, vcrhonek, vdolezal
Target Milestone:	rc	Keywords:	Extras
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rhel-system-roles-1.0-8.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1674004 (view as bug list)		Environment:
Last Closed:	2019-08-06 17:31:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1674004, 1691973

Description Marek Hulan 2019-02-08 17:00:16 UTC

Description of problem:

Satellite 6 requires variables to be listed in defaults/main.yml in order to import/display them in UI. Some of variables such as the one for setting the policy is not listed there and default is hardcoded in tasks/main.yml. After a discussion with pcahyna, it should be posible to extract all of them.

Version-Release number of selected component (if applicable):

last released version, 1.0.0

How reproducible:

allways


Steps to Reproduce:
1. look at role directory
2.
3.

Actual results:

defaults directory is missing

Expected results:

all variables have entry in defaults/main.yml


Additional info:

in master branch, some of variables are already there

Comment 2 Pavel Cahyna 2019-02-08 17:05:45 UTC

The easy cases are there (in master), what is missing is selinux_state and selinux_policy, whose absence has a special meaning. It would be needed to let "null" have this special meaning instead and set the defaults to null.

Comment 6 Pavel Cahyna 2019-04-15 08:31:21 UTC

Do the values matter in any way, or is it enough for the variables to be listed? In some cases the values will be complex Jinja2 expressions, so trying to interpret them would be unlikely to be helpful.

Comment 7 Marek Hulan 2019-04-15 15:26:23 UTC

These values would be imported as default values. If users don't override them, they do not matter and defaults from ansible roles will be used. In other words, feel free to use whatever complicated expression you need, people may see "{{ whatever magic }}" as a default value in UI.

Comment 13 errata-xmlrpc 2019-08-06 17:31:34 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2387