Bug 1676893

Summary: [RFE] Recognize Windows Server 2019 when using qemu-ga
Product: [oVirt] vdsm Reporter: Tomáš Golembiovský <tgolembi>
Component: CoreAssignee: Tomáš Golembiovský <tgolembi>
Status: CLOSED CURRENTRELEASE QA Contact: Petr Matyáš <pmatyas>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 4.30.3CC: bugs, c.handel, godas, lleistne, lrotenbe, michal.skrivanek, middicomhd, musoni, pmatyas, rbarry, tgolembi
Target Milestone: ovirt-4.3.3Keywords: Automation, AutomationBlocker, Regression
Target Release: ---Flags: sbonazzo: ovirt-4.3?
lleistne: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: vdsm-4.30.12 Doc Type: If docs needed, set a value
Doc Text:
Windows 2019 guests running only QEMU Guest Agent were incorrectly reported as Windows 2016. Such guests are now correctly identified in UI.
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-04-16 13:58:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1655503, 1690294    

Description Tomáš Golembiovský 2019-02-13 14:16:37 UTC
Recognize Windows Server 2019 when using qemu-ga

We don't use pretty OS names reported by QEMU Guest Agent because we need to stay compatible with the original names reported by oVirt Guest Agent. Hence the support in bug 1659071 is of minimal use to us. We need our own fix in VDSM.

Comment 1 Michal Skrivanek 2019-02-14 07:54:03 UTC
Hm, what if we change it and use directly? AFAICT it's only about removing the hacky code from VmGuestInfoModel::setGuestOsNamedVersion() and just store the string directly. We do not use the name anywhere else, just display it

Comment 2 Tomáš Golembiovský 2019-02-26 11:31:11 UTC
Posted patches to use pretty-name from qemu-ga

Comment 4 Ryan Barry 2019-03-20 00:51:29 UTC
*** Bug 1690301 has been marked as a duplicate of this bug. ***

Comment 5 Petr Matyáš 2019-03-20 12:28:27 UTC
Adding keywords from duplicate bugs, as the fix for appslist is really important for our automation.

Comment 6 Petr Matyáš 2019-03-29 14:28:27 UTC
How is this supposed to be tested? Because with only RHEV-QGA64 from WGT ISO installed it doesn't report anything to engine/vdsm.

qemu-guest-agent 7.6.2 is installed there and I have vdsm-4.30.12-1.el7ev.x86_64

Comment 7 Tomáš Golembiovský 2019-04-01 20:14:40 UTC
The required version of QEMU-GA has not been released on WGT yet. You need to use an internal build to test that.

Comment 10 Tomáš Golembiovský 2019-04-03 11:18:00 UTC
What is the version of ovirt-engine?

What is the output of `vdsm-client Host getAllVmStats`?

Can you attach debug logs from VDSM?

Comment 12 Petr Matyáš 2019-04-03 14:27:58 UTC
Verified on vdsm-4.30.12-1.el7ev.x86_64

Comment 13 Tomáš Golembiovský 2019-04-09 11:24:55 UTC
*** Bug 1695448 has been marked as a duplicate of this bug. ***

Comment 14 Sandro Bonazzola 2019-04-16 13:58:24 UTC
This bugzilla is included in oVirt 4.3.3 release, published on April 16th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.