Bug 1676893 - [RFE] Recognize Windows Server 2019 when using qemu-ga
Summary: [RFE] Recognize Windows Server 2019 when using qemu-ga
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: Core
Version: 4.30.3
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: ovirt-4.3.3
: ---
Assignee: Tomáš Golembiovský
QA Contact: Petr Matyáš
URL:
Whiteboard:
: 1690301 1695448 (view as bug list)
Depends On:
Blocks: 1655503 1690294
TreeView+ depends on / blocked
 
Reported: 2019-02-13 14:16 UTC by Tomáš Golembiovský
Modified: 2019-04-16 13:58 UTC (History)
11 users (show)

Fixed In Version: vdsm-4.30.12
Doc Type: If docs needed, set a value
Doc Text:
Windows 2019 guests running only QEMU Guest Agent were incorrectly reported as Windows 2016. Such guests are now correctly identified in UI.
Clone Of:
Environment:
Last Closed: 2019-04-16 13:58:24 UTC
oVirt Team: Virt
Embargoed:
sbonazzo: ovirt-4.3?
lleistne: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 97735 0 master ABANDONED guestagent: add support for Windows 2019 2020-04-01 17:55:05 UTC
oVirt gerrit 98053 0 master MERGED core: present guestOs as versioned name for Windows 2020-04-01 17:55:05 UTC
oVirt gerrit 98055 0 master MERGED guestagent: qga: treat pretty-name as guestOs name for Windows 2020-04-01 17:55:05 UTC
oVirt gerrit 98314 0 ovirt-4.3 MERGED guestagent: prefer data from qemu-ga 2020-04-01 17:55:05 UTC
oVirt gerrit 98315 0 ovirt-4.3 MERGED guestagent: qga: treat pretty-name as guestOs name for Windows 2020-04-01 17:55:05 UTC
oVirt gerrit 98476 0 master MERGED guestagent: check if fake appsList is reported 2020-04-01 17:55:05 UTC
oVirt gerrit 98499 0 ovirt-4.3 MERGED guestagent: check if fake appsList is reported 2020-04-01 17:55:05 UTC

Description Tomáš Golembiovský 2019-02-13 14:16:37 UTC 
Recognize Windows Server 2019 when using qemu-ga

We don't use pretty OS names reported by QEMU Guest Agent because we need to stay compatible with the original names reported by oVirt Guest Agent. Hence the support in bug 1659071 is of minimal use to us. We need our own fix in VDSM.
Comment 1 Michal Skrivanek 2019-02-14 07:54:03 UTC 
Hm, what if we change it and use directly? AFAICT it's only about removing the hacky code from VmGuestInfoModel::setGuestOsNamedVersion() and just store the string directly. We do not use the name anywhere else, just display it
Comment 2 Tomáš Golembiovský 2019-02-26 11:31:11 UTC 
Posted patches to use pretty-name from qemu-ga
Comment 4 Ryan Barry 2019-03-20 00:51:29 UTC 
*** Bug 1690301 has been marked as a duplicate of this bug. ***
Comment 5 Petr Matyáš 2019-03-20 12:28:27 UTC 
Adding keywords from duplicate bugs, as the fix for appslist is really important for our automation.
Comment 6 Petr Matyáš 2019-03-29 14:28:27 UTC 
How is this supposed to be tested? Because with only RHEV-QGA64 from WGT ISO installed it doesn't report anything to engine/vdsm.

qemu-guest-agent 7.6.2 is installed there and I have vdsm-4.30.12-1.el7ev.x86_64
Comment 7 Tomáš Golembiovský 2019-04-01 20:14:40 UTC 
The required version of QEMU-GA has not been released on WGT yet. You need to use an internal build to test that.
Comment 10 Tomáš Golembiovský 2019-04-03 11:18:00 UTC 
What is the version of ovirt-engine?

What is the output of `vdsm-client Host getAllVmStats`?

Can you attach debug logs from VDSM?
Comment 12 Petr Matyáš 2019-04-03 14:27:58 UTC 
Verified on vdsm-4.30.12-1.el7ev.x86_64
Comment 13 Tomáš Golembiovský 2019-04-09 11:24:55 UTC 
*** Bug 1695448 has been marked as a duplicate of this bug. ***
Comment 14 Sandro Bonazzola 2019-04-16 13:58:24 UTC 
This bugzilla is included in oVirt 4.3.3 release, published on April 16th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Note You need to log in before you can comment on or make changes to this bug.