Bug 167708
Summary: | Seeing manual pages by man or xscreensaver-demo fails | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mamoru TASAKA <mtasaka> |
Component: | xscreensaver | Assignee: | Ray Strode [halfline] <rstrode> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | jwz, tuxer |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 4.24-3.fc5 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-09-25 10:43:42 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Attachments: |
Description
Mamoru TASAKA
2005-09-07 14:21:01 UTC
Created attachment 118562 [details]
JPEG file which captured the window.
JPEG file of the captured window when I tried the step 2 and step 3.
In this JPEG figure,
A. trying "man xscreensaver" fails with a message "No manual entry".
B. In xscreensaver-demo -> choose bouncingcow -> push Setting -> push
Documentation, gnome-terminal is invoked with displaying garbage messages. Its
title is "/usr/libexec/xscreensaver/bouncingcow manual" and man command sees
the binary file of bouncingcow itself.
Created attachment 118563 [details] Patch A: patch to direct correct manual page on demo Proposed patch A: patch for man command invoked by xscreensaver-demo to direct the correct manual page of the hack. This patch is related to the fix for bug 151677 or bug 156906. After this fix, xscreensaver-demo command came to use the absolute path of the hack binary, but man command invoked by Setting -> Documentation uses this absolute path, too ( at the line of *manualCommand in /usr/X11R6/lib/X11/app-defaults/XScreenSaver ). This patch is intended that for man command, its argument should use only the basename of the hack name with a absolute path. Created attachment 118564 [details] Patch B: move man dir and also change man suffix Patch B: perhaps better fix for bug 166441. When manual pages are moved to section 6, the suffix of manual pages should coincide with the section number. This patch is intended for: 1. Also change man page suffix, too. 2. Restrict man command invoked by xscreensaver-demo to see only in section 6 to avoid seeing the other manual page of the same name in another section. 3. Change the content of the manual page to coincide with section number. For example, ant manual ( in xscreensaver-extras ) includes the description "SEE ALSO xscreensaver(1)". Sorry, rpm version-relase is xscreensaver-4.22-11, not xscreensaver-4.21-11. Hi, Patch B looks reasonable to me. I'll commit it. Thanks. I verified that this bug is fixed in xscreensaver-4.22-13. Thanks !! This bug revived in current rpm xscreensaver-4.24-1 again! Created attachment 124560 [details]
More proper patch, for demo-Gtk.c
More proper approach to fix broken manual pages, for demo-Gtk.c
In fedora rpm version 4.22-4.23, this problem used to be fixed by patching
against XScreensaver.ad.
But after a closer check, it turned to be that this is the bug of the treatment
of a pointer in the function manual_cb() in demo-Gtk.c.
In manual_cb, some pointer movement is executed to find out the basename of a
hack, which proved to be wrong at one point.
This patch is for manual_cb() to find out the basename of a hack correctly;
this patch makes 2 patches above obsolete.
Seemingly fixed in 4.24-3.fc5. *** Bug 161451 has been marked as a duplicate of this bug. *** |