Bug 1677291

Summary:	Review Request: newsboat - An RSS/Atom feed reader for text terminals
Product:	[Fedora] Fedora	Reporter:	Jan Staněk <jstanek>
Component:	Package Review	Assignee:	Igor Raits <igor.raits>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	igor.raits, package-review
Target Milestone:	---	Flags:	igor.raits: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-02-18 14:23:53 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jan Staněk 2019-02-14 13:32:41 UTC

Spec URL: https://copr-be.cloud.fedoraproject.org/results/jstanek/package-reviews/fedora-rawhide-x86_64/00858523-newsboat/newsboat.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jstanek/package-reviews/fedora-rawhide-x86_64/00858523-newsboat/newsboat-2.14.1-1.fc30.src.rpm
Description: Newsboat is a fork of Newsbeuter, an RSS/Atom feed reader for the text console. The only difference is that Newsboat is actively maintained while Newsbeuter isn't.
Fedora Account System Username: jstanek

Note: Although the software is mainly written in C/C++, some parts are recently written in Rust -- so Rust packaging guidelines should probably also apply.

Comment 1 Igor Raits 2019-02-15 13:52:18 UTC

> export CXXFLAGS="${CXXFLAGS:-%optflags}"

Use %set_build_flags instead, please.

Comment 2 Igor Raits 2019-02-15 13:53:15 UTC

> %doc %attr(0644,root,root) %{_mandir}/man1/*
%{_mandir}/man1/*.1

> %doc %{_pkgdocdir}/*
%{_pkgdocdir}

Comment 3 Igor Raits 2019-02-15 13:56:47 UTC

> BuildRequires:  json-devel
> BuildRequires:  json-c-devel
> BuildRequires:  libcurl-devel
> BuildRequires:  libxml2-devel
> BuildRequires:  libxslt-devel
> BuildRequires:  ncurses-devel
> BuildRequires:  pkgconfig
> BuildRequires:  sqlite-devel
> BuildRequires:  stfl-devel
BuildRequires:  pkgconfig(sqlite3)
BuildRequires:  pkgconfig(libcurl)
BuildRequires:  pkgconfig(libxml-2.0)
BuildRequires:  pkgconfig(stfl)
BuildRequires:  pkgconfig(json-c) >= 0.11
BuildRequires:  pkgconfig(ncursesw)
BuildRequires:  pkgconfig(libcrypto)

Comment 4 Jan Staněk 2019-02-15 15:09:10 UTC

Spec URL: https://copr-be.cloud.fedoraproject.org/results/jstanek/package-reviews/fedora-rawhide-x86_64/00858984-newsboat/newsboat.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jstanek/package-reviews/fedora-rawhide-x86_64/00858984-newsboat/newsboat-2.14.1-1.fc30.src.rpm

> Use %set_build_flags instead, please.
TIL that exists, thanks.

> %{_mandir}/man1/*.1
Also TIL that rpm will auto-compress man pages, so the correct version is `%{_mandir}/man1/*.1.gz`

Other changes should be integrated into the spec basically as suggested.

Comment 5 Igor Raits 2019-02-15 16:04:53 UTC

> %{_mandir}/man1/*.1.gz
%{_mandir}/man1/*.1*

Comment 6 Jan Staněk 2019-02-18 14:23:53 UTC

Turns out somebody else has packaged newsboat for Fedora already - whoops.
I will try to merge the result of this review with the existing package.
Thanks for review.

*** This bug has been marked as a duplicate of bug 1590453 ***