Bug 1590453 - Review Request: newsboat - terminal RSS/ATOM feed reader
Summary: Review Request: newsboat - terminal RSS/ATOM feed reader
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1677291 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-12 15:31 UTC by lee
Modified: 2019-02-18 14:23 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-25 15:35:31 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description lee 2018-06-12 15:31:39 UTC
Spec URL: https://pagure.io/newsboat-spec/raw/master/f/newsboat.spec
SRPM URL: https://pagure.io/newsboat-spec/raw/master/f/newsboat-2.11.1-1.fc28.src.rpm
Description: Newsboat is a fork of Newsbeuter, an RSS/Atom feed reader for the text console.
Fedora Account System Username: keitellf

Comment 1 Artur Frenszek-Iwicki 2018-06-12 18:43:16 UTC
>%make_install prefix=/usr
Use %{_prefix}.

Apart from that, looks good to me. Unfortunately I can't do a full review right now.

Comment 2 lee 2018-06-12 20:37:52 UTC
I can't believe I missed that. I'll get it changed. Thank you.

Comment 3 lee 2018-06-12 21:06:53 UTC
The spec file is updated. Same links as above.

Comment 4 lee 2018-06-13 21:46:34 UTC
I've added a temporary workaround for the bug in asciidoc in rawhide. The docs won't be generated for anything greater than 28. Once the problem is resolved I'll remove the workaround.

Please let me know if there's anything else I need to fix.

Comment 5 Robert-André Mauchin 🐧 2018-06-25 13:08:03 UTC
 - %{_datadir}/doc/newsboat/*

Remove the * to also own the directory 

 - Bump to 2.12

 - Use autosetup or %setup -q:

%prep
%autosetup -n %{name}-r%{version}

 - Instead of:

%{_datadir}/locale/**

  use the %find_lang macro:

%install
%make_install prefix=%{_prefix}

%find_lang %{name}

%files -f %{name}.lang
%license LICENSE
%doc README.md



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "Unknown or generated". 252 files have
     unknown license. Detailed output of licensecheck in
     /home/bob/packaging/review/newsboat/review-newsboat/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 51200 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: newsboat-2.11.1-1.fc29.x86_64.rpm
          newsboat-debuginfo-2.11.1-1.fc29.x86_64.rpm
          newsboat-debugsource-2.11.1-1.fc29.x86_64.rpm
          newsboat-2.11.1-1.fc29.src.rpm
newsboat.x86_64: E: explicit-lib-dependency libxml2
newsboat.x86_64: W: no-manual-page-for-binary newsboat
newsboat.x86_64: W: no-manual-page-for-binary podboat
newsboat.src:36: W: setup-not-quiet
4 packages and 0 specfiles checked; 1 errors, 3 warnings.

Comment 6 lee 2018-06-25 13:42:32 UTC
Changes made. Build is successful and installs/runs fine.

Spec URL: https://pagure.io/newsboat-spec/blob/master/f/newsboat.spec
SRPM URL: https://pagure.io/newsboat-spec/blob/master/f/newsboat-2.12-1.fc28.src.rpm

Comment 7 Robert-André Mauchin 🐧 2018-06-25 14:24:52 UTC
Package approved.

Comment 8 Gwyn Ciesla 2018-06-25 14:53:36 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/newsboat

Comment 9 Jan Staněk 2019-02-18 14:23:53 UTC
*** Bug 1677291 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.