Spec URL: https://copr-be.cloud.fedoraproject.org/results/jstanek/package-reviews/fedora-rawhide-x86_64/00858523-newsboat/newsboat.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jstanek/package-reviews/fedora-rawhide-x86_64/00858523-newsboat/newsboat-2.14.1-1.fc30.src.rpm Description: Newsboat is a fork of Newsbeuter, an RSS/Atom feed reader for the text console. The only difference is that Newsboat is actively maintained while Newsbeuter isn't. Fedora Account System Username: jstanek Note: Although the software is mainly written in C/C++, some parts are recently written in Rust -- so Rust packaging guidelines should probably also apply.
> export CXXFLAGS="${CXXFLAGS:-%optflags}" Use %set_build_flags instead, please.
> %doc %attr(0644,root,root) %{_mandir}/man1/* %{_mandir}/man1/*.1 > %doc %{_pkgdocdir}/* %{_pkgdocdir}
> BuildRequires: json-devel > BuildRequires: json-c-devel > BuildRequires: libcurl-devel > BuildRequires: libxml2-devel > BuildRequires: libxslt-devel > BuildRequires: ncurses-devel > BuildRequires: pkgconfig > BuildRequires: sqlite-devel > BuildRequires: stfl-devel BuildRequires: pkgconfig(sqlite3) BuildRequires: pkgconfig(libcurl) BuildRequires: pkgconfig(libxml-2.0) BuildRequires: pkgconfig(stfl) BuildRequires: pkgconfig(json-c) >= 0.11 BuildRequires: pkgconfig(ncursesw) BuildRequires: pkgconfig(libcrypto)
Spec URL: https://copr-be.cloud.fedoraproject.org/results/jstanek/package-reviews/fedora-rawhide-x86_64/00858984-newsboat/newsboat.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jstanek/package-reviews/fedora-rawhide-x86_64/00858984-newsboat/newsboat-2.14.1-1.fc30.src.rpm > Use %set_build_flags instead, please. TIL that exists, thanks. > %{_mandir}/man1/*.1 Also TIL that rpm will auto-compress man pages, so the correct version is `%{_mandir}/man1/*.1.gz` Other changes should be integrated into the spec basically as suggested.
> %{_mandir}/man1/*.1.gz %{_mandir}/man1/*.1*
Turns out somebody else has packaged newsboat for Fedora already - whoops. I will try to merge the result of this review with the existing package. Thanks for review. *** This bug has been marked as a duplicate of bug 1590453 ***