Bug 167885

Summary:	Review Request: libpolyxmass - Polymer chemistry-related functionalities
Product:	[Fedora] Fedora	Reporter:	Andreas Bierfert <andreas.bierfert>
Component:	Package Review	Assignee:	John Mahowald <jpmahowald>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list, jpmahowald
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://www.polyxmass.org
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-10-21 23:29:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 167887

Description Andreas Bierfert 2005-09-09 07:36:06 UTC

Spec Name or Url: http://fedora.lowlatency.de/review/libpolyxmass.spec
SRPM Name or Url: http://fedora.lowlatency.de/review/libpolyxmass-0.8.9-1.src.rpm
Description:
libpolyxmass is a library that implements some housekeeping
functionalities and polymer chemistry-related functionalities that are
used in the other modules of the GNU polyxmass mass spectrometry
framework. It was born as the merge of the two libpxmutils and
libpxmchem libraries (last versions of these two libraries were for
both 0.7.0). This fact is still visible as the files do have either
"pxmutils-" or "pxmchem-" as prefix in their name. This nomenclature
is going to be maintained as it helps understanding the
functionalities that are housed in the different files of the new
library.

Comment 1 John Mahowald 2005-10-20 16:25:24 UTC

Missing BuildRequires: glib2-devel

Minor: rpmlint wants changelog version on the same line: 

W: libpolyxmass no-version-in-last-changelog
W: libpolyxmass-debuginfo no-version-in-last-changelog
W: libpolyxmass-devel no-version-in-last-changelog

Comment 2 Andreas Bierfert 2005-10-20 20:07:03 UTC

fixed missing BR.

changelog in this case is ok because my name is (to) long...
http://fedora.lowlatency.de/review/libpolyxmass-0.8.9-2.src.rpm
http://fedora.lowlatency.de/review/libpolyxmass.spec

Comment 3 John Mahowald 2005-10-20 22:15:43 UTC

The URL line is longer, but oh well.

- license good (GPL), text in %doc
- name follows guidelines
- spec file easily read
- builds on FC4 i386
- rpmlint only warns about changelog, can ignore
- used %find_lang macro
- sources match upstream
- no missing/unneeded BuildRequires
- consistent macro usage
- %post and %postun ldconfig
- devel package only installs a symlink, no need for ldconfig
- %clean good
- *.la removed

However,
- no %defattr for devel package

Comment 4 Andreas Bierfert 2005-10-20 22:22:52 UTC

fixed defattr...

http://fedora.lowlatency.de/review/libpolyxmass-0.8.9-3.src.rpm
http://fedora.lowlatency.de/review/libpolyxmass.spec

Comment 5 John Mahowald 2005-10-21 00:54:48 UTC

Looks good with the defattr added.

APPROVED

Comment 6 Andreas Bierfert 2005-10-21 23:29:56 UTC

Thanks for the review... :)