Red Hat Bugzilla – Bug 167885
Review Request: libpolyxmass - Polymer chemistry-related functionalities
Last modified: 2007-11-30 17:11:13 EST
Spec Name or Url: http://fedora.lowlatency.de/review/libpolyxmass.spec SRPM Name or Url: http://fedora.lowlatency.de/review/libpolyxmass-0.8.9-1.src.rpm Description: libpolyxmass is a library that implements some housekeeping functionalities and polymer chemistry-related functionalities that are used in the other modules of the GNU polyxmass mass spectrometry framework. It was born as the merge of the two libpxmutils and libpxmchem libraries (last versions of these two libraries were for both 0.7.0). This fact is still visible as the files do have either "pxmutils-" or "pxmchem-" as prefix in their name. This nomenclature is going to be maintained as it helps understanding the functionalities that are housed in the different files of the new library.
Missing BuildRequires: glib2-devel Minor: rpmlint wants changelog version on the same line: W: libpolyxmass no-version-in-last-changelog W: libpolyxmass-debuginfo no-version-in-last-changelog W: libpolyxmass-devel no-version-in-last-changelog
fixed missing BR. changelog in this case is ok because my name is (to) long... http://fedora.lowlatency.de/review/libpolyxmass-0.8.9-2.src.rpm http://fedora.lowlatency.de/review/libpolyxmass.spec
The URL line is longer, but oh well. - license good (GPL), text in %doc - name follows guidelines - spec file easily read - builds on FC4 i386 - rpmlint only warns about changelog, can ignore - used %find_lang macro - sources match upstream - no missing/unneeded BuildRequires - consistent macro usage - %post and %postun ldconfig - devel package only installs a symlink, no need for ldconfig - %clean good - *.la removed However, - no %defattr for devel package
fixed defattr... http://fedora.lowlatency.de/review/libpolyxmass-0.8.9-3.src.rpm http://fedora.lowlatency.de/review/libpolyxmass.spec
Looks good with the defattr added. APPROVED
Thanks for the review... :)