Bug 1680376
| Summary: | Review Request: perl-Log-Any-Adapter-TAP - Logging adapter suitable for use in TAP testcases | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Björn Esser (besser82) <besser82> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-03-01 02:38:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1680372 | ||
|
Description
Björn Esser (besser82)
2019-02-24 11:39:27 UTC
Scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=33005545 === Updated package === Changelog: * Sun Feb 24 2019 Björn Esser <besser82> - 0.003003-0.2 - Added explicit perl module compat requires Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/perl-Log-Any-Adapter-TAP.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/perl-Log-Any-Adapter-TAP-0.003003-0.2.fc31.src.rpm Scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=33006263 - %{__perl} → perl
- Use:
BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76
with
perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1
And thus remove:
%{_bindir}/find %{buildroot} -type f -name .packlist -exec rm -f {} \;
%{_bindir}/find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
- Use NO_PERLLOCAL=1:
perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
with
%make_install
instead of
%{__make} pure_install PERL_INSTALL_ROOT=%{buildroot}
- Do not package dist.ini im %files
URL and Source addresses are Ok.
Source archive (SHA-256: 131f0689b2b42b1b31449714c6eda8f811dd96a7c86748f1e03b239cfd0121c0) is original. Ok.
Summary verified from lib/Log/Any/Adapter/TAP.pm. Ok.
Description verified from lib/Log/Any/Adapter/TAP.pm. Ok.
License verified from lib/Log/Any/Adapter/TAP.pm and README. Ok.
No XS code, noarch BuildArch is Ok.
$ rpmlint perl-Log-Any-Adapter-TAP.spec review-perl-Log-Any-Adapter-TAP/results/perl-Log-Any-Adapter-TAP-0.003003-0.2.fc31.noarch.rpm review-perl-Log-Any-Adapter-TAP/results/perl-Log-Any-Adapter-TAP-0.003003-0.2.fc31.src.rpm
perl-Log-Any-Adapter-TAP.noarch: W: spelling-error Summary(en_US) testcases -> test cases, test-cases, suitcases
perl-Log-Any-Adapter-TAP.noarch: W: spelling-error %description -l en_US testcases -> test cases, test-cases, suitcases
perl-Log-Any-Adapter-TAP.noarch: W: spelling-error %description -l en_US diag -> jag, dig, dag
perl-Log-Any-Adapter-TAP.src: W: spelling-error Summary(en_US) testcases -> test cases, test-cases, suitcases
perl-Log-Any-Adapter-TAP.src: W: spelling-error %description -l en_US testcases -> test cases, test-cases, suitcases
perl-Log-Any-Adapter-TAP.src: W: spelling-error %description -l en_US diag -> jag, dig, dag
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
.
$ rpm -q -lv -p perl-Log-Any-Adapter-TAP-0.003003-0.2.fc31.noarch.rpm
drwxr-xr-x 2 root root 0 févr. 24 15:50 /usr/share/doc/perl-Log-Any-Adapter-TAP
-rw-r--r-- 1 root root 1910 févr. 13 2016 /usr/share/doc/perl-Log-Any-Adapter-TAP/Changes
-rw-r--r-- 1 root root 392 févr. 13 2016 /usr/share/doc/perl-Log-Any-Adapter-TAP/README
-rw-r--r-- 1 root root 811 févr. 13 2016 /usr/share/doc/perl-Log-Any-Adapter-TAP/dist.ini
drwxr-xr-x 2 root root 0 févr. 24 15:50 /usr/share/licenses/perl-Log-Any-Adapter-TAP
-rw-r--r-- 1 root root 18355 févr. 13 2016 /usr/share/licenses/perl-Log-Any-Adapter-TAP/LICENSE
-rw-r--r-- 1 root root 3460 févr. 24 15:50 /usr/share/man/man3/Log::Any::Adapter::TAP.3pm.gz
drwxr-xr-x 2 root root 0 févr. 24 15:50 /usr/share/perl5/vendor_perl/Log
drwxr-xr-x 2 root root 0 févr. 24 15:50 /usr/share/perl5/vendor_perl/Log/Any
drwxr-xr-x 2 root root 0 févr. 24 15:50 /usr/share/perl5/vendor_perl/Log/Any/Adapter
-rw-r--r-- 1 root root 13949 févr. 13 2016 /usr/share/perl5/vendor_perl/Log/Any/Adapter/TAP.pm
File permissions and layout are Ok.
$ rpm -q --requires -p perl-Log-Any-Adapter-TAP-0.003003-0.2.fc31.noarch.rpm | sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.28.1)
1 perl(Carp)
1 perl(Data::Dumper)
1 perl(Log::Any)
1 perl(Log::Any::Adapter::Base)
1 perl(parent)
1 perl(Scalar::Util)
1 perl(strict)
1 perl(Try::Tiny)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
Add BR for tests:
BuildRequires: perl(TestLogging)
BuildRequires: perl(Test::Pod::Coverage) >= 1.08
BuildRequires: perl(Pod::Coverage::TrustPod)
rpm -q --provides -p perl-Log-Any-Adapter-TAP-0.003003-0.2.fc31.noarch.rpm
perl(Log::Any::Adapter::TAP) = 0.003003
perl-Log-Any-Adapter-TAP = 0.003003-0.2.fc31
Binary provides are Ok.
Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=33010459).
Ok
Resolution: Package not approved. Please fix all the aforementioned points.
Thank you for the review! (In reply to Robert-André Mauchin from comment #3) > - %{__perl} → perl I think that is a matter of personal preference. Your other remarks have been addressed. *** === Updated package === Changelog: * Sun Feb 24 2019 Björn Esser <besser82> - 0.003003-0.3 - Changes as suggested in review (#1680376) - Add a BR for Perl required version - Add a set of explicit BuildRequires - Use %%make_install - Drop cleanups using find - Drop dist.ini fom %%doc Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/perl-Log-Any-Adapter-TAP.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/perl-Log-Any-Adapter-TAP-0.003003-0.3.fc31.src.rpm Scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=33011455 (In reply to Robert-André Mauchin from comment #3) > Add BR for tests: > > BuildRequires: perl(TestLogging) I don't think this a valid BR, thus removing it again. See: https://koji.fedoraproject.org/koji/taskinfo?taskID=33011455 *** Scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=33011568 I'd be happy if you would review the other dependencies of devscripts, too. ^_^ [1] https://bugzilla.redhat.com/show_bug.cgi?id=1680373 [2] https://bugzilla.redhat.com/show_bug.cgi?id=1680375 [3] https://bugzilla.redhat.com/show_bug.cgi?id=1680372 (In reply to Björn 'besser82' Esser from comment #6) > I'd be happy if you would review the other dependencies of devscripts, too. > ^_^ > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=1680373 > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1680375 > [3] https://bugzilla.redhat.com/show_bug.cgi?id=1680372 I'll take a look when I have the time. Package approved. (In reply to Robert-André Mauchin from comment #7) > (In reply to Björn 'besser82' Esser from comment #6) > > I'd be happy if you would review the other dependencies of devscripts, too. > > ^_^ > > > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=1680373 > > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1680375 > > [3] https://bugzilla.redhat.com/show_bug.cgi?id=1680372 > > I'll take a look when I have the time. Thank you very much! =) (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Log-Any-Adapter-TAP perl-GitLab-API-v4-0.17-1.fc29 perl-HTTP-Tiny-Multipart-0.08-1.fc29 perl-IO-Prompter-0.004015-1.fc29 perl-Log-Any-Adapter-Screen-0.140-1.fc29 perl-Log-Any-Adapter-TAP-0.003003-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-43303fad7f devscripts-2.19.2-3.fc28 perl-GitLab-API-v4-0.17-1.fc28 perl-HTTP-Tiny-Multipart-0.08-1.fc28 perl-IO-Prompter-0.004015-1.fc28 perl-Log-Any-Adapter-Screen-0.140-1.fc28 perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7990f2a050 devscripts-2.19.2-3.fc28 perl-GitLab-API-v4-0.17-1.fc28 perl-HTTP-Tiny-Multipart-0.08-1.fc28 perl-IO-Prompter-0.004015-1.fc28 perl-Log-Any-Adapter-Screen-0.140-1.fc28 perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7990f2a050 devscripts-2.19.2-3.fc28 perl-GitLab-API-v4-0.17-1.fc28 perl-HTTP-Tiny-Multipart-0.08-1.fc28 perl-IO-Prompter-0.004015-1.fc28 perl-Log-Any-Adapter-Screen-0.140-1.fc28 perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7990f2a050 devscripts-2.19.2-3.fc28, perl-GitLab-API-v4-0.17-1.fc28, perl-HTTP-Tiny-Multipart-0.08-1.fc28, perl-IO-Prompter-0.004015-1.fc28, perl-Log-Any-Adapter-Screen-0.140-1.fc28, perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7990f2a050 perl-GitLab-API-v4-0.17-1.fc29, perl-HTTP-Tiny-Multipart-0.08-1.fc29, perl-IO-Prompter-0.004015-1.fc29, perl-Log-Any-Adapter-Screen-0.140-1.fc29, perl-Log-Any-Adapter-TAP-0.003003-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-43303fad7f perl-GitLab-API-v4-0.17-1.fc29, perl-HTTP-Tiny-Multipart-0.08-1.fc29, perl-IO-Prompter-0.004015-1.fc29, perl-Log-Any-Adapter-Screen-0.140-1.fc29, perl-Log-Any-Adapter-TAP-0.003003-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. devscripts-2.19.2-3.fc28, perl-GitLab-API-v4-0.17-1.fc28, perl-HTTP-Tiny-Multipart-0.08-1.fc28, perl-IO-Prompter-0.004015-1.fc28, perl-Log-Any-Adapter-Screen-0.140-1.fc28, perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |