Bug 168175
| Summary: | Review request: perl-Algorithm-Dependency - Algorithm::Dependency Perl module | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralf Corsepius <rc040203> | ||||
| Component: | Package Review | Assignee: | Paul Howarth <paul> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-extras-list, lkundrak | ||||
| Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | http://search.cpan.org/dist/Algorithm-Dependency/ | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2005-09-20 07:25:40 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 168174, 168298 | ||||||
| Bug Blocks: | 163779, 168213 | ||||||
| Attachments: |
|
||||||
|
Description
Ralf Corsepius
2005-09-13 08:23:10 UTC
A new version has been released 1.04. Updated spec and srpm: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Algorithm-Dependency.spec ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Algorithm-Dependency-1.04-1.src.rpm Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, matches spec, text included - spec file written in English and is legible - sources match upstream - package builds OK in mock on FC4 (i386) - BR's mostly OK - no locales, libraries, subpackages or pkgconfigs to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - no large docs - docs don't affect runtime - code, not content - no desktop file needed - no scriptlets Needswork: - URL for Source0 doesn't work: s/www/search/ - should BR: perl(Params::Util) version 0.05, not version 0.5 Nitpick: - last changelog entry should be "Thu Sep 15", not "Tue Sep 15" - add BR: perl(Test::Pod) for better test coverage Created attachment 118840 [details]
Patch addressing review issues
Paul, all the stuff with your patch applied (No further changes). ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Algorithm-Dependency.spec ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Algorithm-Dependency-1.04-2.src.rpm Approved. Package Change Request ====================== Package Name: perl-Algorithm-Dependency New Branches: epel7 Owners: lkundrak The Fedora maintainer (Ralf Corsepius, corsepiu) is not willing to maintain EPEL packages. Git done (by process-git-requests). |