Bug 168175 - Review request: perl-Algorithm-Dependency - Algorithm::Dependency Perl module
Summary: Review request: perl-Algorithm-Dependency - Algorithm::Dependency Perl module
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: David Lawrence
URL: http://search.cpan.org/dist/Algorithm...
Depends On: 168174 168298
Blocks: FE-ACCEPT 168213
TreeView+ depends on / blocked
Reported: 2005-09-13 08:23 UTC by Ralf Corsepius
Modified: 2014-01-21 18:04 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2005-09-20 07:25:40 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
gwync: fedora-cvs+

Attachments (Terms of Use)
Patch addressing review issues (1.53 KB, patch)
2005-09-15 11:52 UTC, Paul Howarth
no flags Details | Diff

Description Ralf Corsepius 2005-09-13 08:23:10 UTC
Spec Name or Url:

SRPM Name or Url:

Algorithmic framework for implementing dependency tree

Comment 2 Paul Howarth 2005-09-15 11:50:51 UTC

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec, text included
- spec file written in English and is legible
- sources match upstream
- package builds OK in mock on FC4 (i386)
- BR's mostly OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- no large docs
- docs don't affect runtime
- code, not content
- no desktop file needed
- no scriptlets


- URL for Source0 doesn't work: s/www/search/
- should BR: perl(Params::Util) version 0.05, not version 0.5


- last changelog entry should be "Thu Sep 15", not "Tue Sep 15"
- add BR: perl(Test::Pod) for better test coverage

Comment 3 Paul Howarth 2005-09-15 11:52:30 UTC
Created attachment 118840 [details]
Patch addressing review issues

Comment 4 Ralf Corsepius 2005-09-16 14:11:15 UTC
Paul, all the stuff with your patch applied (No further changes).


Comment 5 Paul Howarth 2005-09-16 14:25:14 UTC

Comment 6 Lubomir Rintel 2014-01-21 17:52:05 UTC
Package Change Request
Package Name: perl-Algorithm-Dependency
New Branches: epel7
Owners: lkundrak

The Fedora maintainer (Ralf Corsepius, corsepiu) is not willing to maintain EPEL packages.

Comment 7 Gwyn Ciesla 2014-01-21 18:04:39 UTC
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.