Bug 168726

Summary:

Get rid of /usr/bin/eclipse wrapper

Product:

[Fedora] Fedora

Reporter:

Andrew Overholt <overholt>

Component:

eclipse

Assignee:

Igor Foox <ifoox>

Status:

CLOSED RAWHIDE

QA Contact:

Severity:

medium

Docs Contact:

Priority:

medium

Version:

rawhide

CC:

eclipse-bugs

Target Milestone:

---

Keywords:

FutureFeature

Target Release:

---

Hardware:

All

OS:

Linux

Whiteboard:

Fixed In Version:

Doc Type:

Enhancement

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

2006-01-04 19:55:40 UTC

Type:

---

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Bug Depends On:

Bug Blocks:

159880, 175454

Attachments:

Description	Flags
Patch to detect running from a link	none
Patch 2	none
patch 3	none
patch4	none
patch6	none
patch6 (fixed)	none

Description Andrew Overholt 2005-09-19 19:44:33 UTC

Description of problem:
The wrapper script is no longer necessary.  Let's dump it.

Additional info:
Tom Fitzsimmons is waging an all-out war against wrapper scripts and I've
somehow been roped into it :)

Comment 1 Andrew Overholt 2005-10-10 01:02:13 UTC

I attempted to symlink /usr/bin/eclipse to /usr/share/eclipse/eclipse but
Eclipse has internal checks for locations of necessary jars, etc.  I might have
to patch around that.  I'll investigate more.

Comment 2 Billy Biggs 2005-10-10 02:20:12 UTC

It's actually something I discovered a while back but then never had
a chance to fix.  It's entirely fixable in the launcher code (it is in the
CVS module platform-launcher).

https://bugs.eclipse.org/bugs/show_bug.cgi?id=79592

Comment 3 Igor Foox 2005-12-07 18:24:38 UTC

Created attachment 121990 [details]
Patch to detect running from a link

Here's a patch to make the launcher realize that it's being run from a link and
resolve the link using readlink() to find the correct path. It then substitutes
the path for the launcher and also for the the startup.jar.

I'll post this on the upstream bug as well.

Comment 4 Igor Foox 2005-12-07 19:03:55 UTC

Created attachment 121991 [details]
Patch 2

Updated patch, improving indentation to conform to the style used in Eclipse
and taking out debug statements that crept in by mistake.

Comment 5 Igor Foox 2005-12-08 16:13:46 UTC

Closing, the patch was put in Rawhide and FC4 updates-testing

Comment 6 Igor Foox 2005-12-12 16:29:39 UTC

Created attachment 122140 [details]
patch 3

New patch to resolve the problem found in
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=159880 .

Comment 7 Igor Foox 2005-12-12 16:31:19 UTC

Not enough coffee. Above should say problem found in
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175454 .

Comment 8 Igor Foox 2005-12-13 20:59:34 UTC

Created attachment 122196 [details]
patch4

I've commented out the memory freeing from the previous patch because it was
segfaulting when the workbench was restarted from within eclipse. Will test
this out for a bit, and if it seems like this is alright, I will remove the
memory tracking altogether, because it just complicates the patch.

Comment 9 Ben Konrath 2006-01-04 20:31:17 UTC

This fix is also in updates-testing: eclipse-platform-3.1.1-1jpp_1fc.FC4.11

Comment 10 Igor Foox 2006-02-03 17:02:32 UTC

Created attachment 124112 [details]
patch6

I've updated to patch to include the latest fixes but without all the memory
management stuff that was causing errors.

Comment 11 Igor Foox 2006-02-03 17:05:16 UTC

Created attachment 124113 [details]
patch6 (fixed)

Fixed the path to the file.