Bug 1688167

Summary:	Review Request: perl-Math-Polygon - Maintaining polygon data
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Math-Polygon-1.10-1.fc31	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-03-13 14:14:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1688300

Description Petr Pisar 2019-03-13 10:18:54 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Math-Polygon/perl-Math-Polygon.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Math-Polygon/perl-Math-Polygon-1.10-1.fc31.src.rpm
Description:
These Perl modules provide basic transformations on two-dimensional polygons
in pure Perl.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-03-13 12:59:52 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Math-Polygon-1.10-1.fc31.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Carp)
      1 perl(Exporter)
      1 perl(List::Util) >= 1.13
      1 perl(Math::Polygon)
      1 perl(Math::Polygon::Calc)
      1 perl(Math::Polygon::Clip)
      1 perl(Math::Polygon::Transform)
      1 perl(Math::Trig)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(POSIX)
      1 perl(strict)
      1 perl(vars)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Math-Polygon-1.10-1.fc31.noarch.rpm | sort | uniq -c
      1 perl(Math::Polygon) = 1.10
      1 perl-Math-Polygon = 1.10-1.fc31
      1 perl(Math::Polygon::Calc) = 1.10
      1 perl(Math::Polygon::Clip) = 1.10
      1 perl(Math::Polygon::Convex) = 1.10
      1 perl(Math::Polygon::Surface) = 1.10
      1 perl(Math::Polygon::Transform) = 1.10
Binary provides are Ok.

$ rpmlint ./perl-Math-Polygon*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2019-03-13 13:53:34 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Math-Polygon

Comment 3 Petr Pisar 2019-03-13 14:14:50 UTC

Thank you for the review and the repository.