Bug 1688300 - Review Request: perl-Geo-Point - Geographical primitives
Summary: Review Request: perl-Geo-Point - Geographical primitives
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1688167 1688292
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-03-13 13:43 UTC by Petr Pisar
Modified: 2019-03-14 10:50 UTC (History)
2 users (show)

Fixed In Version: perl-Geo-Point-0.98-1.fc31
Clone Of:
Environment:
Last Closed: 2019-03-14 10:50:15 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2019-03-13 13:43:21 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Geo-Point/perl-Geo-Point.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Geo-Point/perl-Geo-Point-0.98-1.fc31.src.rpm
Description:
These Perl modules provide geographical primitives like points, lines,
projections, or polygons. This is implemented as an abstraction above PROJ
library.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-03-13 15:32:31 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Geo-Point-0.98-1.fc31.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Carp)
      1 perl(Geo::Distance) >= 0.06
      1 perl(Geo::Line)
      1 perl(Geo::Point)
      1 perl(Geo::Proj)
      1 perl(Geo::Proj4) >= 1.01
      1 perl(Geo::Shape)
      1 perl(Geo::Space)
      1 perl(Geo::Surface)
      1 perl(List::Util)
      1 perl(Math::Polygon) >= 1.01
      1 perl(Math::Polygon::Calc)
      1 perl(Math::Polygon::Surface)
      1 perl(Math::Trig) >= 1
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(overload)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(vars)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Geo-Point-0.98-1.fc31.noarch.rpm | sort | uniq -c
Binary provides are Ok.

$ rpmlint ./perl-Geo-Point*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Igor Raits 2019-03-14 09:27:18 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Geo-Point

Comment 3 Petr Pisar 2019-03-14 10:50:15 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.