Bug 1688167 - Review Request: perl-Math-Polygon - Maintaining polygon data
Summary: Review Request: perl-Math-Polygon - Maintaining polygon data
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1688300
TreeView+ depends on / blocked
 
Reported: 2019-03-13 10:18 UTC by Petr Pisar
Modified: 2019-03-13 14:14 UTC (History)
2 users (show)

Fixed In Version: perl-Math-Polygon-1.10-1.fc31
Clone Of:
Environment:
Last Closed: 2019-03-13 14:14:50 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2019-03-13 10:18:54 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Math-Polygon/perl-Math-Polygon.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Math-Polygon/perl-Math-Polygon-1.10-1.fc31.src.rpm
Description:
These Perl modules provide basic transformations on two-dimensional polygons
in pure Perl.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-03-13 12:59:52 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Math-Polygon-1.10-1.fc31.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Carp)
      1 perl(Exporter)
      1 perl(List::Util) >= 1.13
      1 perl(Math::Polygon)
      1 perl(Math::Polygon::Calc)
      1 perl(Math::Polygon::Clip)
      1 perl(Math::Polygon::Transform)
      1 perl(Math::Trig)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(POSIX)
      1 perl(strict)
      1 perl(vars)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Math-Polygon-1.10-1.fc31.noarch.rpm | sort | uniq -c
      1 perl(Math::Polygon) = 1.10
      1 perl-Math-Polygon = 1.10-1.fc31
      1 perl(Math::Polygon::Calc) = 1.10
      1 perl(Math::Polygon::Clip) = 1.10
      1 perl(Math::Polygon::Convex) = 1.10
      1 perl(Math::Polygon::Surface) = 1.10
      1 perl(Math::Polygon::Transform) = 1.10
Binary provides are Ok.

$ rpmlint ./perl-Math-Polygon*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2019-03-13 13:53:34 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Math-Polygon

Comment 3 Petr Pisar 2019-03-13 14:14:50 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.