Bug 1688945

Summary: babel FTBFS with pytest 4.3
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: babelAssignee: Miro Hrončok <mhroncok>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: fschwarz, jeff, nphilipp
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-06-05 14:51:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1671167, 1686977    
Attachments:
Description Flags
build.log from copr none

Description Miro Hrončok 2019-03-14 18:26:12 UTC 
Created attachment 1544152 [details]
build.log from copr

While bootstrapping babel in copr for Python 3.8, I've realized it fails to run %check with pytest 4.3.

==================================== ERRORS ====================================
______ ERROR at setup of test_no_inherit_metazone_marker_never_in_output _______
file /builddir/build/BUILD/Babel-2.6.0/tests/test_dates.py, line 769
  @pytest.mark.all_locales
  def test_no_inherit_metazone_marker_never_in_output(locale):
E       fixture 'locale' not found
>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, os_environ, pytestconfig, record_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
>       use 'pytest --fixtures [testpath]' for help on them.
/builddir/build/BUILD/Babel-2.6.0/tests/test_dates.py:769
______________________ ERROR at setup of test_smoke_dates ______________________
file /builddir/build/BUILD/Babel-2.6.0/tests/test_smoke.py, line 17
  @pytest.mark.all_locales
  def test_smoke_dates(locale):
E       fixture 'locale' not found
>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, os_environ, pytestconfig, record_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
>       use 'pytest --fixtures [testpath]' for help on them.
/builddir/build/BUILD/Babel-2.6.0/tests/test_smoke.py:17
_____________________ ERROR at setup of test_smoke_numbers _____________________
file /builddir/build/BUILD/Babel-2.6.0/tests/test_smoke.py, line 27
  @pytest.mark.all_locales
  def test_smoke_numbers(locale):
E       fixture 'locale' not found
>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, os_environ, pytestconfig, record_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
>       use 'pytest --fixtures [testpath]' for help on them.
/builddir/build/BUILD/Babel-2.6.0/tests/test_smoke.py:27
Comment 1 Miro Hrončok 2019-03-14 18:29:04 UTC 
The locale "fixture" should come from here:

https://github.com/python-babel/babel/blob/69cda1d2082444ed99836d92135f175d20555463/tests/conftest.py#L12
Comment 2 Felix Schwarz 2019-04-10 12:32:35 UTC 
Hi Miro: I saw your pull request which looks good to me (though I don't know much about pytest). I guess we should just pull in that patch for Fedora as there is no official Babel release with it? (I'm ok with that.)
Comment 3 Jeffrey C. Ollie 2019-04-10 14:36:14 UTC 
I'm fine with whatever you all agree on. I'm not an active maintainer anymore so someone else will need to take point on this.
Comment 4 Miro Hrončok 2019-04-10 14:40:38 UTC 
OK. I'll take this and either use our patch or update when the time comes. Thanks
Comment 5 Miro Hrončok 2019-06-05 14:51:42 UTC 
2.7.0 includes this