Created attachment 1544152 [details] build.log from copr While bootstrapping babel in copr for Python 3.8, I've realized it fails to run %check with pytest 4.3. ==================================== ERRORS ==================================== ______ ERROR at setup of test_no_inherit_metazone_marker_never_in_output _______ file /builddir/build/BUILD/Babel-2.6.0/tests/test_dates.py, line 769 @pytest.mark.all_locales def test_no_inherit_metazone_marker_never_in_output(locale): E fixture 'locale' not found > available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, os_environ, pytestconfig, record_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory > use 'pytest --fixtures [testpath]' for help on them. /builddir/build/BUILD/Babel-2.6.0/tests/test_dates.py:769 ______________________ ERROR at setup of test_smoke_dates ______________________ file /builddir/build/BUILD/Babel-2.6.0/tests/test_smoke.py, line 17 @pytest.mark.all_locales def test_smoke_dates(locale): E fixture 'locale' not found > available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, os_environ, pytestconfig, record_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory > use 'pytest --fixtures [testpath]' for help on them. /builddir/build/BUILD/Babel-2.6.0/tests/test_smoke.py:17 _____________________ ERROR at setup of test_smoke_numbers _____________________ file /builddir/build/BUILD/Babel-2.6.0/tests/test_smoke.py, line 27 @pytest.mark.all_locales def test_smoke_numbers(locale): E fixture 'locale' not found > available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, os_environ, pytestconfig, record_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory > use 'pytest --fixtures [testpath]' for help on them. /builddir/build/BUILD/Babel-2.6.0/tests/test_smoke.py:27
The locale "fixture" should come from here: https://github.com/python-babel/babel/blob/69cda1d2082444ed99836d92135f175d20555463/tests/conftest.py#L12
Hi Miro: I saw your pull request which looks good to me (though I don't know much about pytest). I guess we should just pull in that patch for Fedora as there is no official Babel release with it? (I'm ok with that.)
I'm fine with whatever you all agree on. I'm not an active maintainer anymore so someone else will need to take point on this.
OK. I'll take this and either use our patch or update when the time comes. Thanks
2.7.0 includes this