Bug 171505
| Summary: | Review Request: digikamimageplugins: Plugins for digikam | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list |
| Target Milestone: | --- | Flags: | petersen:
fedora-cvs-
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://extragear.kde.org/apps/digikamimageplugins/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-11-01 15:44:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Rex Dieter
2005-10-21 21:38:03 UTC
Build fails in mock: Making all in adjustlevels make[3]: Entering directory `[...]/digikamimageplugins/adjustlevels' /usr/lib/qt-3.3/bin/moc ./adjustlevels.h -o adjustlevels.moc /usr/lib/qt-3.3/bin/moc ./imageplugin_adjustlevels.h -o imageplugin_adjustlevels.moc creating digikamimageplugin_adjustlevels_la.all_cpp.cpp ... /bin/sh ../../libtool [...] -c -o digikamimageplugin_adjustlevels_la.all_cpp.lo digikamimageplugin_adjustlevels_la.all_cpp.cpp /bin/sh ../../libtool [...] digikamimageplugin_adjustlevels_la.all_cpp.lo -lkparts -ldigikam grep: /usr/lib/libgdbm.la: No such file or directory /bin/sed: can't read /usr/lib/libgdbm.la: No such file or directory libtool: link: `/usr/lib/libgdbm.la' is not a valid libtool archive make[3]: *** [digikamimageplugin_adjustlevels.la] Error 1 Gotta love libtool. Looks like a digikam bug (not omitting libtool archives), bug #171503 %changelog * Sat Oct 22 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.7.4-2 - BR: gdbm-devel (workaround for digikam bug #171503) Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/digikamimageplugins-0.7.4-2.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/digikamimageplugins-0.7.4-2.src.rpm %changelog * Sat Oct 22 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.7.4-3 - follow icon spec (touch icon theme dir) Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/digikamimageplugins-0.7.4-3.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/digikamimageplugins-0.7.4-3.src.rpm Build failed again in mach, this time requirering /usr/lib/libkipi.la (but we don't ship it anymore) By the way, some lines are more than 80 cols in the description. %changelog * Sat Oct 22 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.7.4-4 - %%description: < 80 columns - BR: libkipi-devel, libkexif-devel, gphoto2-devel, imlib2-devel (workaround for digikam bug #171503) Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/digikamimageplugins-0.7.4-4.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/digikamimageplugins-0.7.4-4.src.rpm Review for release 4: * RPM name is OK * Source digikamimageplugins-0.7.4.tar.bz2 is the same as upstream * Builds fine in mock * rpmlint of digikamimageplugins looks OK * File list of digikamimageplugins looks OK * Plugins are detected by digikam, and work fine. I would approve it but for the scriptlets not running gtk-update-icon-cache. I understand your point about not running it, therefore I'm adding the bug as a dependency. fine, I'll re-add the gtk-update-icon-cache call... I just needed to vent... (-: Blockers have been worked-around, removing...
%changelog
* Sat Oct 22 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.7.4-5
- %%post,%%postun: gtk-update-icon-cache
- drop %%{?debug_package}
- drop CVS tags
Spec Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/SPECS/digikamimageplugins-0.7.4-5.spec
SRPM Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/digikamimageplugins-0.7.4-5.src.rpm
Yeah, I understand, it's quite a pain in the bottom... I hope the cron job will be added before everybody has updated their spec file... OK, looks good. APPROVED. Package Change Request ====================== Package Name: digikamimageplugins [Updated Fedora Owners: mgarski Is the intention to add a comaintainer or a change of package ownership? Please clarify and set fedora-cvs to '?' again. |