Bug 1716584

Summary:	Review Request: rust-try_or - Contains helper macros for unwrapping Results and Options
Product:	[Fedora] Fedora	Reporter:	Robert Fairley <rfairley>
Component:	Package Review	Assignee:	Igor Raits <igor.raits>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	dustymabe, ego.cordatus, igor.raits, lucab, package-review, rfairley
Target Milestone:	---	Flags:	igor.raits: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-06-09 16:11:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1716673

Description Robert Fairley 2019-06-03 17:19:40 UTC

Spec URL: https://copr-be.cloud.fedoraproject.org/results/rfairley/rust-try_or/fedora-rawhide-x86_64/00920427-rust-try_or/rust-try_or.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/rfairley/rust-try_or/fedora-rawhide-x86_64/00920427-rust-try_or/rust-try_or-0.2.0-1.fc31.src.rpm
Description: Contains helper macros for unwrapping Results and Options. See more: https://crates.io/crates/try_or
Fedora Account System Username: rfairley

Dependency of libsystemd [1] which is to be packaged in Fedora, for FCOS [2]

[1] https://crates.io/crates/libsystemd
[2] https://github.com/coreos/fedora-coreos-tracker/issues/190

Comment 1 Robert Fairley 2019-06-04 13:19:10 UTC

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35252171

Comment 2 Artem 2019-06-06 16:24:30 UTC

Package was generated through rust2rpm, simplifying the review considerably.

! No license file
! Dot in summary
! Issue with naming package. The maintainer MUST NOT use an underscore '_'
  https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_separators

Comment 3 Igor Raits 2019-06-06 16:26:53 UTC

This does not apply to the rust packages....

Comment 4 Artem 2019-06-06 16:29:31 UTC

Package approved.

Comment 5 Igor Raits 2019-06-06 16:30:40 UTC

But please, remove dot from summary and add license files.

Comment 6 Robert Fairley 2019-06-07 19:31:14 UTC

Thanks for the review! Fixed the 2 nits.

New specfile: https://copr-be.cloud.fedoraproject.org/results/rfairley/rust-try_or/fedora-rawhide-x86_64/00928425-rust-try_or/rust-try_or.spec
New SRPM: https://copr-be.cloud.fedoraproject.org/results/rfairley/rust-try_or/fedora-rawhide-x86_64/00928425-rust-try_or/rust-try_or-0.2.0-1.fc31.src.rpm

Comment 7 Igor Raits 2019-06-09 15:28:56 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-try_or