Bug 1716584 - Review Request: rust-try_or - Contains helper macros for unwrapping Results and Options
Summary: Review Request: rust-try_or - Contains helper macros for unwrapping Results a...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Igor Raits
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1716673
TreeView+ depends on / blocked
 
Reported: 2019-06-03 17:19 UTC by Robert Fairley
Modified: 2019-06-09 16:11 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-06-09 16:11:47 UTC
Type: ---
Embargoed:
igor.raits: fedora-review+


Attachments (Terms of Use)

Description Robert Fairley 2019-06-03 17:19:40 UTC
Spec URL: https://copr-be.cloud.fedoraproject.org/results/rfairley/rust-try_or/fedora-rawhide-x86_64/00920427-rust-try_or/rust-try_or.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/rfairley/rust-try_or/fedora-rawhide-x86_64/00920427-rust-try_or/rust-try_or-0.2.0-1.fc31.src.rpm
Description: Contains helper macros for unwrapping Results and Options. See more: https://crates.io/crates/try_or
Fedora Account System Username: rfairley

Dependency of libsystemd [1] which is to be packaged in Fedora, for FCOS [2]

[1] https://crates.io/crates/libsystemd
[2] https://github.com/coreos/fedora-coreos-tracker/issues/190

Comment 1 Robert Fairley 2019-06-04 13:19:10 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35252171

Comment 2 Artem 2019-06-06 16:24:30 UTC
Package was generated through rust2rpm, simplifying the review considerably.

! No license file
! Dot in summary
! Issue with naming package. The maintainer MUST NOT use an underscore '_'
  https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_separators

Comment 3 Igor Raits 2019-06-06 16:26:53 UTC
This does not apply to the rust packages....

Comment 4 Artem 2019-06-06 16:29:31 UTC
Package approved.

Comment 5 Igor Raits 2019-06-06 16:30:40 UTC
But please, remove dot from summary and add license files.

Comment 7 Igor Raits 2019-06-09 15:28:56 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-try_or


Note You need to log in before you can comment on or make changes to this bug.