Bug 1716673 - Review Request: rust-libsystemd - A pure-Rust client library to work with systemd
Summary: Review Request: rust-libsystemd - A pure-Rust client library to work with sys...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Artem
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1716584
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-03 21:28 UTC by Robert Fairley
Modified: 2019-06-09 19:32 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-06-09 19:32:31 UTC
Type: ---
Embargoed:
ego.cordatus: fedora-review+

Attachments (Terms of Use)
Patch quickcheck crate version to 0.8 (350 bytes, patch)
2019-06-03 21:32 UTC, Robert Fairley 		no flags Details | Diff
View All

Description Robert Fairley 2019-06-03 21:28:52 UTC 
Spec URL: https://copr-be.cloud.fedoraproject.org/results/rfairley/rust-libsystemd/fedora-rawhide-x86_64/00920522-rust-libsystemd/rust-libsystemd.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/rfairley/rust-libsystemd/fedora-rawhide-x86_64/00920522-rust-libsystemd/rust-libsystemd-0.1.0-1.fc31.src.rpm
Description: A pure-Rust client library to work with systemd. See more: https://crates.io/crates/libsystemd
Fedora Account System Username: rfairley

Dependency of Zincati [1] which is to be packaged in Fedora, for FCOS [2]

[1] https://github.com/coreos/zincati
[2] https://github.com/coreos/fedora-coreos-tracker/issues/190
Comment 1 Robert Fairley 2019-06-03 21:32:00 UTC 
Created attachment 1576754 [details]
Patch quickcheck crate version to 0.8

Patches the source with the change in https://github.com/lucab/libsystemd-rs/pull/13.
Comment 2 Robert Fairley 2019-06-03 21:34:08 UTC 
Note: this depends on the `try_or` crate being packaged https://bugzilla.redhat.com/show_bug.cgi?id=1716584.
Comment 3 Artem 2019-06-06 16:28:48 UTC 
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

! No license file.
! Need dot in end of description.

Otherwise OK. Package approved.
Comment 4 Igor Raits 2019-06-09 15:20:32 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libsystemd
Note You need to log in before you can comment on or make changes to this bug.